feat!: Remove non-cli logic from cli.run_plan #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1080 +/- ##
==========================================
- Coverage 95.05% 95.03% -0.03%
==========================================
Files 41 41
Lines 2528 2537 +9
==========================================
+ Hits 2403 2411 +8
- Misses 125 126 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DiamondJoseph
approved these changes
Jun 24, 2025
| @@ -194,10 +197,12 @@ def get_active_task(self) -> WorkerTask: | |||
|
|
|||
| return self._rest.get_active_task() | |||
|
|
|||
| @start_as_current_span(TRACER, "task", "timeout") | |||
| @start_as_current_span(TRACER, "name", "parameters", "timeout") | |||
There was a problem hiding this comment.
Given the problems we've had with the logs being spammed with junk I'm hesitant to add a dict here, but I suppose better to add it and change the underlying behaviour that's causing problems.
There was a problem hiding this comment.
I think the same content would have ended up in the logs when a task was being passed around. It still contained the same dict.
Argument parsing has been moved into a click option validator, and task creation has been moved into the client create_task methods. This is a breaking change in the BlueapiClient as task methods now accept plan name and parameters as separate arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argument parsing has been moved into a click option validator, and task
creation has been moved into the client create_task methods.
This is a breaking change in the BlueapiClient as task methods now
accept plan name and parameters as separate arguments.
Fixes #593 leaving only CLI related code in
run_planincli.py.