feat: Insert documents into Tiled #755
Conversation
DiamondJoseph
force-pushed
the
tiled-insertion
branch
from
324c226 to
f3767e1
Compare
pyproject.toml
Outdated
| @@ -95,7 +99,8 @@ addopts = """ | |||
| --ignore=src/blueapi/startup | |||
| """ | |||
| # https://iscinumpy.gitlab.io/post/bound-version-constraints/#watch-for-warnings | |||
| filterwarnings = ["error", "ignore::DeprecationWarning"] | |||
| # Unignore UserWarning after Pydantic warning removed from bluesky/bluesky and release | |||
There was a problem hiding this comment.
- a release of bluesky
There was a problem hiding this comment.
Should: Include issue link in a comment in the file
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
==========================================
- Coverage 94.48% 94.31% -0.17%
==========================================
Files 41 41
Lines 2555 2570 +15
==========================================
+ Hits 2414 2424 +10
- Misses 141 146 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pyproject.toml
Outdated
| @@ -95,7 +99,8 @@ addopts = """ | |||
| --ignore=src/blueapi/startup | |||
| """ | |||
| # https://iscinumpy.gitlab.io/post/bound-version-constraints/#watch-for-warnings | |||
| filterwarnings = ["error", "ignore::DeprecationWarning"] | |||
| # Unignore UserWarning after Pydantic warning removed from bluesky/bluesky and release | |||
| filterwarnings = ["error", "ignore::DeprecationWarning", "ignore::UserWarning"] | |||
There was a problem hiding this comment.
Is there any way to only ignore warnings from the tests in question? Otherwise we may end up removing this in a few months time only to find the tests blowing up in a bunch of other places?
src/blueapi/service/interface.py
Outdated
| @@ -48,6 +50,19 @@ def worker() -> TaskWorker: | |||
| return worker | |||
|
|
|||
|
|
|||
| @cache | |||
| def tiled_inserter(): | |||
There was a problem hiding this comment.
Should:
| def tiled_inserter(): | |
| def tiled_inserter() -> TiledClient: |
...or whatever it's called
pyproject.toml
Outdated
| @@ -95,7 +99,8 @@ addopts = """ | |||
| --ignore=src/blueapi/startup | |||
| """ | |||
| # https://iscinumpy.gitlab.io/post/bound-version-constraints/#watch-for-warnings | |||
| filterwarnings = ["error", "ignore::DeprecationWarning"] | |||
| # Unignore UserWarning after Pydantic warning removed from bluesky/bluesky and release | |||
There was a problem hiding this comment.
Should: Include issue link in a comment in the file
DiamondJoseph
force-pushed
the
tiled-insertion
branch
from
e9406e5 to
019dd47
Compare
DiamondJoseph
changed the title
| @@ -148,6 +157,9 @@ def setup(config: ApplicationConfig) -> None: | |||
| ) | |||
|
|
|||
| stomp_client() | |||
| if config.tiled.enabled: | |||
There was a problem hiding this comment.
Would this check be better in the tiled_writer method (which then returns TiledWriter | None) so it's not relying on the config being checked externally? This could then be
if writer := tiled_writer():
context().run_engine.subscribe(writer)Maybe need to make it tiled_writer(TiledConfig) -> TiledWriter | None so that the caching still works if the config ever changes (does it?).
No description provided.