Tidy Helm action #771
Closed
Tidy Helm action #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumforrester
requested changes
Jan 7, 2025
Comment on lines
-19
to
-32
| - name: Validate SemVer2 version compliance | ||
| if: startsWith(github.ref, 'refs/tags/') | ||
| env: | ||
| SEMVER_REGEX: ^(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(-[0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*)?(\+[0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*)?$ | ||
|
|
||
| run: | | ||
| ref="${{ github.ref_name }}" | ||
| my_regex="${{env.SEMVER_REGEX}}" | ||
| if [[ "$ref" =~ $my_regex ]]; then | ||
| echo "SemVer compliant version: $ref" | ||
| else | ||
| echo "Invalid SemVer version: $ref" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
As discussed offline, I would like proof we don't need this
There was a problem hiding this comment.
@DiamondJoseph given my recent mishap releasing something with the wrong tag, should we just put something like this into the check CI and have it only run on a tag, such that the entire pipeline fails early if someone tries to push an invalid tag?
|
@DiamondJoseph could you manually create a set of two tags off this branch and then run the actions for them - one correct and running and the other incorrect and rejected? |
|
Superseded by #880. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.