test(opencode): guard against re-exporting parseCommandFile (#631)#632
Open
nethmadtharuka wants to merge 1 commit into
Open
test(opencode): guard against re-exporting parseCommandFile (#631)#632nethmadtharuka wants to merge 1 commit into
nethmadtharuka wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #631.
The underlying bug (OpenCode's legacy getLegacyPlugins() loader calling every named export as a plugin factory) was already fixed on main in #301, which moved parseCommandFile into its own .cjs sibling. That fix isn't in any tagged release yet though — checked v4.8.0 through v4.8.4, none include commit 511ddd4.
This adds a regression test that asserts ponytail.mjs has no named exports besides default, so this can't silently regress. Verified it fails against the pre-#301 shape and passes on current main.