fix: drain Codex SessionStart stdin#635
Open
chief-impact7 wants to merge 1 commit into
Open
Conversation
Constraint: Windows wrappers may leave stdin open indefinitely Rejected: Wait unbounded for EOF | freezes Windows sessions Confidence: high Scope-risk: narrow Directive: Stdin-independent hooks must drain with a bounded self-exit fallback Tested: node --test tests/hooks.test.js tests/hooks-windows.test.js Not-tested: pandas correctness benchmark is independently failing its 1s subprocess timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Codex can write a large SessionStart payload after this hook has already emitted its output. Exiting immediately closes the read end and makes Codex report
failed to write hook stdin: Broken pipe (os error 32).Tests
node --test tests/hooks.test.js tests/hooks-windows.test.js(8/8 passed)node --check hooks/ponytail-activate.js