chore(skill): add menlo-persistence agentskills.io skill#250
Merged
DigiBanks99 merged 1 commit intomainfrom Apr 12, 2026
Merged
chore(skill): add menlo-persistence agentskills.io skill#250DigiBanks99 merged 1 commit intomainfrom
DigiBanks99 merged 1 commit intomainfrom
Conversation
Adds the menlo-persistence skill to skills/menlo-persistence/ so AI-assisted agents can implement future EF Core + PostgreSQL persistence slices correctly and consistently without re-deriving the architectural conventions from scratch. The skill covers: - Project layout: Menlo.Application as the sole EF Core project, domain model staying in Menlo.Lib - Slice interface pattern (IUserContext, IBudgetContext, etc.) — feature handlers never inject MenloDbContext directly - Entity type configuration conventions: ToTable with schema, numeric(18,4) for monetary values, automatic snake_case via EFCore.NamingConventions, no manual HasColumnName() calls - Strongly typed ID → uuid mapping via central value converters - ISoftDeletable contract + SoftDeleteInterceptor + global query filter wired in OnModelCreating - IAuditable contract + AuditingInterceptor (EntityState.Added / Modified) - AddMenloApplication() DI registration pattern with interceptors and slice interface scoped registrations - TestContainers-only testing policy (in-memory EF Core prohibited) - Migration commands with exact --project / --startup-project flags Also includes: - references/patterns.md: full working C# code examples for every convention (DbContext skeleton, DI extension, interceptors, slice interface, entity type config, TestContainers fixture, example integration tests) - evals/evals.json: 3 benchmark evals (BudgetEntry full slice, IUserContext integration tests, HouseholdMember entity) with 24 graded assertions; iteration-1 results: 100% with-skill vs 66% without-skill (delta +34pp) Co-authored-by: Copilot <[email protected]>
b53dead to
5eb4594
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
menlo-persistenceagentskills.io skill toskills/menlo-persistence/so that AI-assisted agents can implement future EF Core + PostgreSQL persistence slices correctly and consistently, without re-deriving architectural conventions from scratch on each task.Closes #243
What's in the skill
SKILL.mdcovers:Menlo.Applicationis the sole EF Core project; domain model stays inMenlo.LibIUserContext/IBudgetContextetc., neverMenloDbContextdirectlyToTablewith schema,numeric(18,4)for monetary values, automatic snake_case viaEFCore.NamingConventions, noHasColumnName()callsConfigureConventionsISoftDeletable: contract +SoftDeleteInterceptor+ global query filter inOnModelCreatingIAuditable: contract +AuditingInterceptor(fires onEntityState.Added/Modified)AddMenloApplication(): DI registration with interceptors + scoped slice interface registrations--project/--startup-projectflagsreferences/patterns.mdprovides full working C# code examples for every convention:MenloDbContextskeleton, DI extension, both interceptors, slice interface, entity type config, TestContainers fixture, and example integration tests.evals/evals.jsoncontains 3 benchmark evals with 24 graded assertions:BudgetEntryfull persistence slice (entity + config + interface + DI + migration)IUserContextintegration tests (TestContainers, fresh scopes, soft-delete, audit)HouseholdMemberentity (schema placement, typed ID, ISoftDeletable, IHouseholdContext)Benchmark results (iteration 1)
Key failures in the without-skill baseline:
ToTable(e.g.,"budget"schema omitted)numeric(18,2)instead ofnumeric(18,4)HasColumnName()calls instead of relying on snake_case conventionEnsureCreatedinstead ofMigrateAsyncin test fixtures--projectflag in migration commandsAcceptance criteria
references/patterns.md)