Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
e2xauthoringandpackagesdirectories to improve path handling, refactor code, and enhance functionality. The most important changes include updating path handling to useos.path.realpath, refactoring theTaskclass, and adding a callback to theSetGitAuthorDialogcomponent.Path Handling Improvements:
e2xauthoring/models/pool.py: Updated thepathattribute in thePoolclass to useos.path.realpathfor resolving the absolute path.e2xauthoring/models/task.py: Updated thepathattribute in theTaskclass to useos.path.realpathfor resolving the absolute path.Refactoring:
e2xauthoring/models/task.py: Refactored thecopymethod in theTaskclass to use a new_rename_notebookhelper method for renaming notebooks.API Changes:
packages/api/src/api.js: Modified therenameandcopymethods in theAPIobject to change the parameter name fromold_nametoname.Component Enhancements:
packages/app/src/components/alerts/GitAuthorNotSetAlert.jsx: Added a newhandleAuthorSetfunction to update the state when the Git author is set.packages/app/src/components/dialogs/SetGitAuthorDialog.jsx: Added anonAuthorSetcallback to theSetGitAuthorDialogcomponent to notify when the Git author is set. [1] [2]