Upgrade to Rails 7.2 #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code quality scoreLovely, the code quality is unchanged for this PR 😊
|
|
I know this app is pretty lightweight, but might be nice to confirm we don't have any differences with https://railsdiff.org/7.1.0/7.2.2.2 - at first glance I don't see any overlaps, but would be cool to confirm :) |
Contributor
Author
Have checked this and it looks to be all good 👍 |
paul-mesnilgrente
approved these changes
Oct 15, 2025
Contributor
paul-mesnilgrente
left a comment
paul-mesnilgrente
left a comment
There was a problem hiding this comment.
I guess it makes sense to only support Rails that hasn't reached its EOL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade SJ Client to Rails 7.2