feat: add theme preference (system/dark/light)#116
feat: add theme preference (system/dark/light)#116baptisteArno wants to merge 6 commits intoDimillian:mainfrom
Conversation
|
Hmm completely removed transparency for me when I checked out this PR |
|
Ok let me investigate |
|
Do you confirm you have Reduce transparency off? And if you change that setting, you still can't see any transparency? |
|
Thanks for this, indeed I could reproduce and fix it 🙏 |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a350029ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .app.theme-light { | ||
| --text-primary: #1a1d24; | ||
| --text-strong: #0e1118; |
There was a problem hiding this comment.
Apply light-theme variables outside the .app tree
The light theme variables are now scoped to .app.theme-light, which means any UI rendered outside the .app subtree will keep the dark defaults from :root. This shows up in portals like the workspace add menu (Sidebar.tsx uses createPortal(..., document.body)), which are no longer descendants of .app. When a user selects the light theme (or system is light), these popovers still render with dark colors, creating a mixed theme. Consider applying the theme class to body/:root or moving the light overrides there so portals inherit the correct variables.
Useful? React with 👍 / 👎.
|
Requires deeper changes to make it work with native Window Vibrancy. Will open a new one. |


CleanShot.2026-01-19.at.10.58.45.mp4
Decisions: