Skip to content

Add 3-way Transparency mode (glass/blur/reduced) and migrate legacy setting#205

Closed
Dimillian wants to merge 1 commit intomainfrom
codex/update-settings-panel-transparency-options
Closed

Add 3-way Transparency mode (glass/blur/reduced) and migrate legacy setting#205
Dimillian wants to merge 1 commit intomainfrom
codex/update-settings-panel-transparency-options

Conversation

@Dimillian
Copy link
Copy Markdown
Owner

Motivation

  • Replace the old boolean "Reduce transparency" toggle with a mode-based TransparencyMode to support macOS 26 Liquid Glass (glass/blur/reduced) while keeping sensible fallbacks for Linux and older macOS.
  • Preserve existing user intent by migrating the legacy reduceTransparency value to the new mode and default to glass where supported.

Description

  • Introduced the TransparencyMode type and storage/key migration from the legacy reduceTransparency boolean to a new transparencyMode (glass|blur|reduced).
  • Implemented useTransparencyPreference() to read legacy settings, persist transparencyMode in localStorage, detect isGlassSupported() and expose transparencyMode, setTransparencyMode, availableModes, and glassSupported.
  • Updated useLiquidGlassEffect() to accept transparencyMode and apply the correct behavior: enable Liquid Glass for glass, use the platform Effect.HudWindow/blur for blur, and clear effects for reduced (also disabling Liquid Glass when leaving glass).
  • Wired the new API through useAppSettingsController() and App.tsx, updated app class application to use transparencyMode === "reduced" for the legacy CSS hook.
  • Reworked settings UI: replaced the single toggle with a segmented control showing available modes (Glass, Blur, Reduced) and added styles for the segmented control; updated unit tests to use the new props/behaviour.

Testing

  • Ran npm run lint; completed with warnings (TypeScript version warning and an existing react-hooks/exhaustive-deps warning in GitDiffViewer.tsx).
  • Ran npm run test (vitest run) and all tests passed.
  • Ran npm run typecheck (tsc --noEmit) and type-checking passed with no errors.

Codex Task

@Dimillian
Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Dimillian Dimillian closed this Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant