Add transparency modes (glass/blur/reduced) and fix re-enabling Liquid Glass#207
Closed
Add transparency modes (glass/blur/reduced) and fix re-enabling Liquid Glass#207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
enabled: truewhen applying Liquid Glass and replacing the binaryreduceTransparencyflag with a three-valueTransparencyModeto expressglass,blur, orreducedbehaviors.Description
enabled: trueinsrc/features/app/hooks/useLiquidGlassEffect.tswhen applying theglassmode and added logic to disable the effect when the mode is notglass, while updating the hook to accepttransparencyModeinstead of a boolean.useTransparencyPreferencewith a richer implementation insrc/features/layout/hooks/useTransparencyPreference.tsthat persiststransparencyMode(migrates fromreduceTransparency), checksisGlassSupported, exposesavailableModes, and providessetTransparencyMode.useAppSettingsController.tsandApp.tsxto usetransparencyMode,setTransparencyMode, andtransparencyModesinstead ofreduceTransparency.SettingsView.tsx,SettingsView.test.tsx,src/styles/settings.css, andsrc/types.tsto add the segmented radiogroup UI for transparency modes, associated styles, test adjustments, and theTransparencyModetype.Testing
SettingsView.test.tsxwere updated to match the newtransparencyModeAPI but were not run as part of this rollout.Codex Task