Conversation
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
gersmann
pushed a commit
to gersmann/codex-monitor-web
that referenced
this pull request
Mar 10, 2026
zip700
pushed a commit
to zip700/CodexMonitor
that referenced
this pull request
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
AppHandleintorequest_microphone_permissionand ensuretrigger_microphone_permission_request()is invoked viarun_on_main_threadso the system dialog appears reliably on macOS insrc-tauri/src/dictation.rs.apphandle through thedictation_startcall site and update the non-macOS stub to accept the same signature for parity.Testing
npm run lintwith no lint errors reported (passed).npm run typecheck(tsc --noEmit) with no type errors reported (passed).Codex Task