Skip to content

fix: macOS dictation mic permission prompt on main thread#215

Merged
Dimillian merged 1 commit intomainfrom
codex/github-mention-issue-microphone-permission-not-requested
Jan 23, 2026
Merged

fix: macOS dictation mic permission prompt on main thread#215
Dimillian merged 1 commit intomainfrom
codex/github-mention-issue-microphone-permission-not-requested

Conversation

@Dimillian
Copy link
Copy Markdown
Owner

Motivation

  • The microphone permission dialog on macOS could fail to appear because the permission request was not dispatched on the main thread, causing dictation startup to proceed without showing the system prompt.

Description

  • Plumb an AppHandle into request_microphone_permission and ensure trigger_microphone_permission_request() is invoked via run_on_main_thread so the system dialog appears reliably on macOS in src-tauri/src/dictation.rs.
  • Wire the app handle through the dictation_start call site and update the non-macOS stub to accept the same signature for parity.
  • Use a oneshot channel to propagate errors from the main-thread call back to the async permission flow and surface failures appropriately.

Testing

  • Ran npm run lint with no lint errors reported (passed).
  • Ran npm run typecheck (tsc --noEmit) with no type errors reported (passed).

Codex Task

@Dimillian Dimillian changed the title Fix macOS dictation mic permission prompt on main thread fix: macOS dictation mic permission prompt on main thread Jan 23, 2026
@Dimillian
Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Dimillian Dimillian merged commit 1ef0cb1 into main Jan 23, 2026
5 checks passed
gersmann pushed a commit to gersmann/codex-monitor-web that referenced this pull request Mar 10, 2026
zip700 pushed a commit to zip700/CodexMonitor that referenced this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant