Skip to content

feat: add branch search and validation in header popover#229

Merged
Dimillian merged 4 commits intomainfrom
codex/update-title-bar-branch-popover
Jan 25, 2026
Merged

feat: add branch search and validation in header popover#229
Dimillian merged 4 commits intomainfrom
codex/update-title-bar-branch-popover

Conversation

@Dimillian
Copy link
Copy Markdown
Owner

Motivation

  • Improve branch popover UX by making the branch list searchable and using the existing branch ordering (most-recent first) when presenting results.
  • Allow quick creation of a branch from the search field and provide client-side validation and inline feedback to prevent invalid names.

Description

  • Replaced the old create-toggle UI with a single searchable input that filters branches by substring and falls back to the most-recent 12 branches when the query is empty.
  • Pressing Enter will either create a new branch (when the query has no exact match) or checkout an exact match (when different from the current branch), and the search is cleared after actions or when the popover closes.
  • Added comprehensive client-side branch name validation rules (disallowing reserved names, spaces, invalid characters like ~, ^, :, ?, *, [, \, @{, .., .lock, leading/trailing /, trailing .) and surfaced validation messages in the popover.
  • Added CSS for the search row, disabled create button state, and a small create hint (.branch-search, .branch-create-hint, and disabled .branch-create-button).

Testing

  • Ran npm run lint and it completed successfully.
  • Ran npm run typecheck (tsc --noEmit) and it completed successfully.

Codex Task

@Dimillian
Copy link
Copy Markdown
Owner Author

@codex review

@Dimillian Dimillian changed the title Add branch search and validation in header popover feat: add branch search and validation in header popover Jan 25, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0fde4d9895

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/features/app/components/MainHeader.tsx
The backend no longer checks out the branch after creation, and the UI button label is updated from 'Create + checkout' to 'Create' to reflect this change.
After creating a new branch, the function now checks out the branch instead of just returning Ok(()). This ensures the repository is switched to the new branch immediately after creation.
@Dimillian Dimillian merged commit 5dbfa7a into main Jan 25, 2026
4 checks passed
gersmann pushed a commit to gersmann/codex-monitor-web that referenced this pull request Mar 10, 2026
zip700 pushed a commit to zip700/CodexMonitor that referenced this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant