Add hold-to-quit progress bar and experimental toggle#238
Add hold-to-quit progress bar and experimental toggle#238jmcte wants to merge 3 commits intoDimillian:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f279abbca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "app_quit" => { | ||
| if should_hold_to_quit(app) { | ||
| emit_menu_event(app, "menu-quit"); | ||
| } else { | ||
| app.exit(0); |
There was a problem hiding this comment.
When hold-to-quit is enabled, the macOS quit menu path no longer calls app.exit(0) and instead only emits menu-quit to the main window. If the renderer isn’t ready (early startup) or has crashed/hung, no listener will ever call requestAppQuit, so the Quit menu/accelerator becomes a no-op and the app cannot exit normally. Consider adding a fallback exit when no window exists or after a short timeout if the event isn’t handled.
Useful? React with 👍 / 👎.
|
Fun but extremely weird |
2 participants
Summary
Testing
Closes #237