change to make codex detection work in case of windows build#296
Closed
souhaiebtar wants to merge 3 commits intoDimillian:mainfrom
Closed
change to make codex detection work in case of windows build#296souhaiebtar wants to merge 3 commits intoDimillian:mainfrom
souhaiebtar wants to merge 3 commits intoDimillian:mainfrom
Conversation
Refactor PATH handling to detect codex cli when installed on windows using npm
There was a problem hiding this comment.
Pull request overview
Refactors codex CLI discovery/execution to behave correctly on Windows builds, primarily by making PATH handling OS-aware and changing how the codex command is launched on Windows.
Changes:
- Build PATH using
env::split_paths/env::join_pathsinstead of hard-coded:splitting. - Add a Windows-only helper to suppress spawning an extra console window.
- On Windows, execute codex via
nodefor.jstargets orcmd /Cfor wrapper-style installs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added tests for build_codex_path_env() and build_codex_command_with_bin()
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Owner
|
I have 0 trust in Copilot model, but feel free to open another PR with the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor PATH handling to detect codex cli when installed on windows using npm