-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat: add Windows support (updater + dictation) #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
a2f1afd
docs: add Windows support spec and plan
amanthanvi 0d1c674
fix: improve cross-platform path opening
amanthanvi 3b14fd4
feat(dictation): enable Windows support
amanthanvi 54ea0f6
ci: add Windows build job
amanthanvi 9b533f5
ci(release): add Windows updater artifacts
amanthanvi 30cad9b
docs: clarify Windows updater bundle
amanthanvi 2544941
fix: make default Open in targets platform-aware
amanthanvi 8195845
ci: ensure LLVM available on Windows
amanthanvi a49d3bc
docs: remove macOS-only framing
amanthanvi 17b6e21
Fix doctor command detection
amanthanvi 125647a
Keep Windows plan/spec current
amanthanvi 1738da8
Fix Codex PATH handling on Windows
amanthanvi 12f17cb
Show shortcuts with Ctrl on Windows
amanthanvi 1d07666
Fix Windows shortcut labels and select theming
amanthanvi ee26759
Document Windows UX and Codex PATH requirements
amanthanvi 3091919
Run Codex via cmd.exe on Windows
amanthanvi e3417dd
Make settings copy platform-neutral
amanthanvi d7a2b30
Use generic file manager icon on Windows
amanthanvi 2856368
Fix platform label in Sentry metrics
amanthanvi 10abdb9
Use platform-neutral default font stacks
amanthanvi 0172c47
Refresh docs copy for Windows support
amanthanvi 6bcf130
Fix Windows open-in commands (.cmd/.bat shims)
amanthanvi 04ebaea
Guard platform detection for non-browser contexts
amanthanvi 353a763
Fix Windows asset globs in release workflow
amanthanvi a2909b6
Fix Windows Codex process lifecycle
amanthanvi 85c9e2a
Harden Windows cmd spawning for Codex
amanthanvi 4c5b26d
Fix Windows open-in cmd wrappers
amanthanvi b8b4e94
Make default shortcuts Windows-friendly
amanthanvi 3ba7875
Update Windows plan for shortcut defaults
amanthanvi f69dfd2
Merge origin/main into feature/windows-support
amanthanvi 24d2cdd
Fix Windows cmd wrapper escaping
amanthanvi dc329be
Tighten doctor and unify platform detection
amanthanvi e0d5e5b
Make file manager labels platform-aware
amanthanvi 26ad51d
Reuse shared platform detection
amanthanvi 30c7c42
Compute default shortcuts at runtime
amanthanvi f295a6b
Use target_os cfg in types
amanthanvi a175a9d
Improve Windows installer selection in release workflow
amanthanvi b75df92
Normalize cmd+ctrl shortcuts on non-mac
amanthanvi ce7d86e
Merge branch 'main' into feature/windows-support
Dimillian 7845450
Merge remote-tracking branch 'origin/main' into feature/windows-support
Dimillian 277771a
chore(rust): remove unused codex args helper
Dimillian 5dd8005
chore(docs): remove plan and spec docs
Dimillian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Windows installer detection logic searches for .exe files containing "setup" or "installer" in lowercase filenames, with a fallback to the first .exe found if no match. This heuristic approach could be fragile if:
Consider either:
*_x64-setup.exeor similar)For robustness, at minimum add a log message showing which installer was selected.