[codex] Add default service tier setting#593
Draft
SamsurTee wants to merge 1 commit intoDimillian:mainfrom
Draft
[codex] Add default service tier setting#593SamsurTee wants to merge 1 commit intoDimillian:mainfrom
SamsurTee wants to merge 1 commit intoDimillian:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This adds a persistent default service tier setting to CodexMonitor and exposes it in Settings under
Codex -> Default parameters.Users can now choose a default
Service tier(default / off,fast, orflex) that applies whenever a workspace or thread does not already have a thread-scoped override.Why this changed
Fast mode was previously only persisted as workspace-local UI state in thread parameter storage. That meant existing workspaces could remember Fast mode once
/fasthad been used, but newly created projects did not inherit any default and always started with Fast mode off.Model and reasoning effort already had app-level defaults, but service tier did not. This change makes service tier behave consistently with those existing defaults.
User impact
Users can now set Fast mode as the default for new projects without needing to run
/fastin each workspace.Behavior after this change:
off(null) still disables Fast modeRoot cause
serviceTierwas stored only in thread/workspace local storage, whileAppSettingspersisted onlylastComposerModelIdandlastComposerReasoningEffort. New projects therefore had no saved__no_thread__service tier seed to inherit from.Validation
npm run typechecknpm run test -- src/features/app/orchestration/useThreadOrchestration.test.ts src/features/threads/utils/threadCodexParamsSeed.test.ts src/features/settings/components/SettingsView.test.tsxNotes
I did not run Rust-side compilation in this environment because the local machine did not have the Rust toolchain installed yet.