Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default features when fullstack is enabled and one platform is enabled in the default features #3925

Merged
merged 4 commits into from
Apr 7, 2025

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Mar 27, 2025

When you have a cargo.toml like this:

[dependencies]
dioxus = { version = "0.6.3", features = ["fullstack"] }

[features]
default = ["web"]
web = ["dioxus/web"]
server = ["dioxus/server"]

The CLI currently tries to include the web feature in your server build which can cause unexpected behavior. This PR fixes that issue and adds a regression test

Closes #3740
Closes #3491

@ealmloff ealmloff added cli Related to the dioxus-cli program fullstack related to the fullstack crate labels Mar 27, 2025
@ealmloff ealmloff requested a review from a team as a code owner March 27, 2025 22:42
@jkelleyrtp jkelleyrtp merged commit 8c866b7 into main Apr 7, 2025
16 of 17 checks passed
@jkelleyrtp jkelleyrtp deleted the fix-cli-features branch April 7, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the dioxus-cli program fullstack related to the fullstack crate
Projects
None yet
2 participants