Skip to content

signals: Rebuild stale global cache entries automatically #4809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

signals: Rebuild stale global cache entries automatically #4809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion packages/signals/src/global/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,12 +182,27 @@ where
let context = get_global_context();

// Get the entry if it already exists
let mut evicted_stale_entry = false;
{
let read = context.map.borrow();
if let Some(signal) = read.get(&key) {
return signal.downcast_ref::<T>().cloned().unwrap();
if let Some(signal) = signal.downcast_ref::<T>() {
return signal.clone();
}
evicted_stale_entry = true;
#[cfg(debug_assertions)]
tracing::warn!(
?key,
stored_type = ?signal.type_id(),
expected_type = std::any::type_name::<T>(),
expected_type_id = ?std::any::TypeId::of::<T>(),
"Global signal cache entry type mismatch; rebuilding entry"
);
}
}
if evicted_stale_entry {
context.map.borrow_mut().remove(&key);
}
// Otherwise, create it
// Constructors are always run in the root scope
let signal = dioxus_core::Runtime::current().in_scope(ScopeId::ROOT, || {
Expand Down
Loading