ENG-1456: Migrate personal boolean flag consumers (getSetting → getPersonalSetting)

[sid597]

https://www.loom.com/share/e63f0beb46e84ee7b0d279174a37942e

---

Summary by CodeRabbit

• Refactor
  • Migrated all user-configurable settings from global application storage to per-user personal settings. Individual preferences for feedback visibility, canvas overlays, keyboard shortcuts, diagnostic tracking, sidebar behavior, query metadata display, and styling options are now preserved uniquely for each user rather than being shared globally.

[linear]

ENG-1456 Migrate personal boolean flag consumers (getSetting → getPersonalSetting)

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

• ENG-1468: Port node and relations tree based consumers #822
• ENG-1467: Port global setting consumer reads (→ getGlobalSetting) #821
• ENG-1473: Port non-boolean personal setting consumers #818
• ENG-1456: Migrate personal boolean flag consumers (getSetting → getPersonalSetting) #814 👈 (View in Graphite)
• ENG-1472: Refactor BlockPropSettingPanels to add accessor-backed default reads #813
• ENG-1455: Dual-read from old-system settings and from blockprops #812
• ENG-1465: Add "Use new settings store" feature flag  #811
• ENG-1217: Port section component in left sidebar #804
• ENG-1328: Port small blueprint based misc settings into props based #805
• eng-1438-keyboard-quick-shortcut-keystriggers

This stack of pull requests is managed by Graphite. Learn more about stacking.

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR migrates feature flag and preference retrievals from global extension settings (via getSetting) to personal per-user settings (via getPersonalSetting). The changes affect 12 files across components, utilities, and settings UI, establishing personal settings as the single source of truth for user preferences.

Changes

Cohort / File(s)	Summary
Canvas & UI Components apps/roam/src/components/DiscourseFloatingMenu.tsx, apps/roam/src/components/canvas/DiscourseNodeUtil.tsx, apps/roam/src/components/canvas/Tldraw.tsx, apps/roam/src/components/canvas/uiOverrides.tsx	Replaced runtime extension API setting checks with getPersonalSetting calls for feature toggles: feedback button visibility, overlay/canvas relations preferences, and discourse tool keyboard shortcut.
Settings UI Configuration apps/roam/src/components/settings/HomePersonalSettings.tsx, apps/roam/src/components/settings/QuerySettings.tsx	Removed getSetting usage and initialValue props from PersonalFlagPanel components; initialization now relies on component defaults rather than explicit per-item defaults read from extension settings.
Settings Infrastructure apps/roam/src/components/settings/utils/accessors.ts	Removed legacy default overrides map (PERSONAL_OLD_DEFAULT_OVERRIDES) and simplified getLegacyPersonalSetting to always read defaults from DEFAULT_PERSONAL_SETTINGS.
Core Utilities & Initialization apps/roam/src/index.ts, apps/roam/src/utils/initializeObserversAndListeners.ts, apps/roam/src/utils/createDiscourseNode.ts	Replaced getSetting calls with getPersonalSetting for diagnostics, styling, overlay, and sidebar preferences; one location adds return statement to propagate creation promise in page action listener.
Error Handling & Analytics apps/roam/src/utils/internalError.ts, apps/roam/src/utils/posthog.ts	Replaced getSetting with getPersonalSetting for "Disable product diagnostics" flag in error reporting and PostHog initialization flows.
Command Palette apps/roam/src/utils/registerCommandPaletteCommands.ts	Updated toggle commands to read settings via getPersonalSetting, sync both extension and personal settings on update, and include error messages in toast notifications.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• ENG-1273: Migrate small personal settings #691: Directly related—makes identical code-level changes (replacing getSetting/extension API calls with getPersonalSetting) across the same files (DiscourseFloatingMenu, createDiscourseNode, initializeObserversAndListeners, HomePersonalSettings).
• ENG-1190 Replace existing roam-js components with blockProp based ones #689: Related—both modify the settings UI layer and PersonalFlagPanel component signatures for personal/global setting panels.
• ENG-636 Add auto canvas relations setting to user preferences #363: Related—both modify the AUTO_CANVAS_RELATIONS gating logic in DiscourseNodeUtil and Tldraw to conditionally create canvas relations based on user preference.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and accurately summarizes the main change: migrating personal boolean flag consumers from getSetting to getPersonalSetting across multiple files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[mdroidian]

A couple comments.

• Let's make a task to change the getPersonalSetting to a typed value or shared constant.
• Could you communicate the context for why we are removing initialValue and what it's being replaced with?

[mdroidian]

Could we promote this to a shared constant or typed key? That would give us autocomplete and eliminate the risk of subtle string mismatches.

Ideally that's something we look into doing before merging to main.

[sid597]

We can, it depends on what the end goal is. I am coming from the pov that this is intermediate code that is not going to be merged to main, we are merging all this to a staging branch, testing it thoroughly internally then removing the intermediate code i.e both the dual-write and dual-read.

So if this is intermediate then we should not update this code, if the end goal is that we will merge this main and then do real world testing and monitoring, and at some point in future cleanup the intermediate code, then we should do this.

[mdroidian]

It can be for the future, as long as it is tracked somewhere. Ideally a linear ticket.

[sid597]

ENG-1499: Convert legacy-blockprop key pairs to shared constant or typed key

[mdroidian]

What is initialValue being replaced with?

[sid597]

Before: Callers read the value manually and passed it as initialValue:

  <PersonalFlagPanel                                                 
    settingKeys={["Discourse context overlay"]}                      
    initialValue={getSetting<boolean>("discourse-context-overlay",   
  false)}             
  />          

After: PersonalFlagPanel reads it internally — same lookup, just moved inside:

  <PersonalFlagPanel
    settingKeys={["Discourse context overlay"]}
  />

The wrapper does getPersonalSetting(settingKeys) which calls the
same getSetting(legacyKey, zodDefault) under the hood. The legacy
key mapping ("Discourse context overlay" → "discourse-context-overlay") and default (false) come from the
accessor layer now instead of the call site.

This was set up in ENG-1472 — PersonalFlagPanel (#813) already self-reads,
so the initialValue props were redundant.

[devin-ai-integration]

Devin Review found 1 new potential issue.

View 12 additional findings in Devin Review.