Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
maparent
force-pushed
the
eng-681-automate-database-testing
branch
from
b8a505d to
0f2384d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
maparent
force-pushed
the
eng-681-automate-database-testing
branch
from
ccb043f to
a28e59d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
maparent
force-pushed
the
eng-681-automate-database-testing
branch
from
536026a to
8129898
Compare
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
Could you address the graphite/Devon comments then re-request review, please?
|
The first one had been addressed, forgot to resolve. The second one came afterwards, corrected. |
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
Let's change the file name to follow the existing naming convention before merging.
| } else if ( | ||
| process.env.HOME === "/vercel" || | ||
| process.env.GITHUB_ACTIONS !== undefined | ||
| (process.env.GITHUB_ACTIONS === "true" && |
There was a problem hiding this comment.
If majority of the changes in a file are formatting, it's helpful to call that out and identify the non-formatting changes explicitly so reviewers can focus on the meaningful differences.
| @@ -0,0 +1,87 @@ | |||
| import { spawn, execSync } from "node:child_process"; | |||
There was a problem hiding this comment.
Let's follow the existing naming convention please.
2 participants
https://linear.app/discourse-graphs/issue/ENG-681/automate-database-testing
https://www.loom.com/share/effc31754c2e44f6a1113669a4632eea
Created a script that starts the database functions and then runs the test in parallel.
(supabase itself is started by the pnpm task)
This requires the
SUPABASE_PROJECT_IDto be set to test, to avoid clobbering developer's docker database.Caching the docker images does not seem to speed things up in practice.