Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new properties on disnake.File class #855

Merged
merged 28 commits into from
Jan 10, 2023
Merged

feat: add new properties on disnake.File class #855

merged 28 commits into from
Jan 10, 2023

Conversation

Snipy7374
Copy link
Collaborator

@Snipy7374 Snipy7374 commented Nov 6, 2022 •
edited
Loading

Summary

This PR closes

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

a special thanks goes to @ilynoid that helped me to design some properties

@Snipy7374 Snipy7374 changed the title feat: add new properties on disnake.File class feat: add new properties on disnake.File class Nov 6, 2022
@shiftinv shiftinv added t: enhancement New feature s: needs review Issue/PR is awaiting reviews labels Nov 6, 2022
Enegg
Enegg reviewed Nov 6, 2022
View reviewed changes
Enegg
Enegg reviewed Nov 6, 2022
View reviewed changes
@shiftinv shiftinv linked an issue Nov 10, 2022 that may be closed by this pull request
add new properties on disnake.File class #839
Closed
Victorsitou
Victorsitou reviewed Dec 24, 2022
View reviewed changes
Snipy7374 and others added 2 commits December 24, 2022 16:29
@Snipy7374 @Victorsitou
Update disnake/file.py
a1df2c6 
Co-authored-by: Victor <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
@Snipy7374 @Victorsitou
Update changelog/839.feature.rst
4028894 
Co-authored-by: Victor <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
shiftinv
shiftinv reviewed Dec 27, 2022
View reviewed changes
@shiftinv shiftinv added this to the disnake v2.8 milestone Dec 27, 2022
@Snipy7374 Snipy7374 requested a review from shiftinv January 1, 2023 21:39
shiftinv
shiftinv approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the documentation nit, lgtm. thanks!

@shiftinv shiftinv merged commit a5232d0 into DisnakeDev:master Jan 10, 2023
@Snipy7374 Snipy7374 deleted the dev-PR branch January 15, 2023 14:56
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enegg Enegg Enegg left review comments

@Victorsitou Victorsitou Victorsitou left review comments

@ilynoid ilynoid ilynoid left review comments

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.8
Development

Successfully merging this pull request may close these issues.

add new properties on disnake.File class
6 participants
@Snipy7374 @shiftinv @Enegg @Victorsitou @ilynoid @onerandomusername