Skip to content

Refactor/migrate transactions viem#88

Open
Rav1Chauhan wants to merge 3 commits intoDjedAlliance:mainfrom
Rav1Chauhan:refactor/migrate-transactions-viem
Open

Refactor/migrate transactions viem#88
Rav1Chauhan wants to merge 3 commits intoDjedAlliance:mainfrom
Rav1Chauhan:refactor/migrate-transactions-viem

Conversation

@Rav1Chauhan
Copy link

Addressed Issues:

Part of the phased migration from web3.js to viem.
Fixes #79

Screenshots/Recordings:

Not applicable — this PR modifies SDK-level transaction handling and does not introduce UI changes.

Additional Notes:

This PR migrates transaction preparation logic from web3.js to viem.

Changes included:

Replaced djed.methods(...).encodeABI() usage

Removed buildTx dependency

Introduced viem transaction configuration object

Used parseUnits for value handling

No removal of web3 dependency yet (to be handled in a later PR)

Checklist

  • [x ] My PR addresses a single issue, fixes a single bug or makes a single improvement.
  • [ x] My code follows the project's code style and conventions.
  • If applicable, I have made corresponding changes or additions to the documentation.
  • If applicable, I have made corresponding changes or additions to tests.
  • [ x] My changes generate no new warnings or errors.
  • [ x] I have joined the Stability Nexus's Discord server and I will share a link to this PR with the project maintainers there.
  • [ x] I have read the Contribution Guidelines.
  • [ x] Once I submit my PR, CodeRabbit AI will automatically review it and I will address CodeRabbit's comments.

⚠️ AI Notice - Important!

We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact.

@Rav1Chauhan
Copy link
Author

assign it to me .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor to Viem and Remove Web3.js

1 participant