Fix: Remove comma formatting from fractional part in decimalScaling#92
Fix: Remove comma formatting from fractional part in decimalScaling#92Rav1Chauhan wants to merge 1 commit intoDjedAlliance:mainfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Addressed Issues:
Fixes #70
Screenshots/Recordings:
Not applicable.
Additional Notes:
Problem
The decimalScaling helper applied intersperseCommas() to the fractional (decimal) portion of the number.
This caused incorrect formatting such as:
0.123,456
Commas should only be used as thousands separators in the integer part, not in the fractional part.
Checklist
We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact.