Spiral #2
Open
Spiral #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurii-litvinov
requested changes
Oct 16, 2017
Collaborator
yurii-litvinov
left a comment
yurii-litvinov
left a comment
There was a problem hiding this comment.
Всё ок, но плохо с некорректным вводом --- надо больше тестов и адекватную реакцию на плохие случаи
|
|
||
| for (int i = 0; i < data.length; i++) { | ||
| for (int j = 0; j < data.length; j++) { | ||
| matrix[i][j] = data[j][i]; |
Collaborator
There was a problem hiding this comment.
Это хорошо, если в data лежат данные в правильном формате. Для public-методов public-классов на это никогда не следует рассчитывать
| int[][] matrix = new int[][]{{3, 1, 5}, | ||
| {54, 43, 32}, | ||
| {21, 53, 76}}; | ||
| SpiralMatrix spiral = new SpiralMatrix(matrix); |
Collaborator
There was a problem hiding this comment.
Сама переменная не нужна, вызвали конструктор и забыли
| } | ||
|
|
||
| @Test | ||
| public void testPrintMatrix15x5() { |
|
|
||
| assertEquals("3", outContent.toString().trim()); | ||
| } | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
Хочется ещё тесты на корректное поведение на некорректном вводе. null-ы, неквадратные матрицы, матрицы с чётными длинами массивов, "рваные" матрицы
yurii-litvinov
approved these changes
Oct 16, 2017
| @@ -0,0 +1,4 @@ | |||
| package ru.spbau.mit.kazakov.SpiralMatrix; | |||
|
|
|||
| public class EvenDimensionException extends Exception { | |||
Collaborator
There was a problem hiding this comment.
К исключениям тоже нужны комментарии, например, в каких ситуациях бросается
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.