ZipFile! #4
Open
ZipFile! #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurii-litvinov
approved these changes
Nov 12, 2017
Collaborator
yurii-litvinov
left a comment
yurii-litvinov
left a comment
There was a problem hiding this comment.
Существенных замечаний нет, зачтена
| = new File("src" + File.separator + "test" + File.separator + "resources").getAbsolutePath(); | ||
| @Before | ||
| public void clearTestingFolder() throws IOException { | ||
| File testingFolder = new File(ABSOLUTE_PATH_TO_RESOURCES + File.separator + "testing folder"); |
Collaborator
There was a problem hiding this comment.
На винде так не работает, пробел в пути смущает
|
|
||
| Collection<File> filesInTestingFolder = FileUtils.listFiles(testingFolder, null, true); | ||
| for (File file : filesInTestingFolder) { | ||
| //if(file.isFile()){ |
Collaborator
There was a problem hiding this comment.
Закомментированный код не нужен в основной ветке
| * @param path to archive | ||
| * @param regexp to satisfy | ||
| */ | ||
| private static void unzipMatchedFiles(String zipFile, String path, String regexp) throws IOException { |
Collaborator
There was a problem hiding this comment.
Nullability-аннотации полезно писать и для private-методов, тут они будут проверять, что сам код написан правильно
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.