Use legacy Adam on macOS when tensorflow-metal is installed#28
Open
Copilot wants to merge 13 commits into
Open
Use legacy Adam on macOS when tensorflow-metal is installed#28Copilot wants to merge 13 commits into
Copilot wants to merge 13 commits into
Conversation
Agent-Logs-Url: https://github.com/DocGarbanzo/donkeycar/sessions/2554f4db-1330-4137-b772-07f64d9a3372 Co-authored-by: DocGarbanzo <47540921+DocGarbanzo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/DocGarbanzo/donkeycar/sessions/2554f4db-1330-4137-b772-07f64d9a3372 Co-authored-by: DocGarbanzo <47540921+DocGarbanzo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/DocGarbanzo/donkeycar/sessions/2554f4db-1330-4137-b772-07f64d9a3372 Co-authored-by: DocGarbanzo <47540921+DocGarbanzo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/DocGarbanzo/donkeycar/sessions/2554f4db-1330-4137-b772-07f64d9a3372 Co-authored-by: DocGarbanzo <47540921+DocGarbanzo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/DocGarbanzo/donkeycar/sessions/2554f4db-1330-4137-b772-07f64d9a3372 Co-authored-by: DocGarbanzo <47540921+DocGarbanzo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/DocGarbanzo/donkeycar/sessions/2554f4db-1330-4137-b772-07f64d9a3372 Co-authored-by: DocGarbanzo <47540921+DocGarbanzo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/DocGarbanzo/donkeycar/sessions/2554f4db-1330-4137-b772-07f64d9a3372 Co-authored-by: DocGarbanzo <47540921+DocGarbanzo@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
DocGarbanzo
May 12, 2026 06:58
View session
DocGarbanzo
requested changes
May 12, 2026
Owner
DocGarbanzo
left a comment
DocGarbanzo
left a comment
There was a problem hiding this comment.
The tests are bad. We want a test that shows proper convergence on a tf model using adam. Do we not have a small dataset checked in? If not, then create a standalone model similar to the linear model or even just a feed forward nn and prove the convergence there.
Agent-Logs-Url: https://github.com/DocGarbanzo/donkeycar/sessions/93138dfa-e218-44ea-90b5-f7d4f973fc1e Co-authored-by: DocGarbanzo <47540921+DocGarbanzo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/DocGarbanzo/donkeycar/sessions/93138dfa-e218-44ea-90b5-f7d4f973fc1e Co-authored-by: DocGarbanzo <47540921+DocGarbanzo@users.noreply.github.com>
Author
Updated tests to use a real standalone TensorFlow model and assert convergence with Adam-based training, including the Metal+legacy Adam path when available ( |
Agent-Logs-Url: https://github.com/DocGarbanzo/donkeycar/sessions/258cc849-6d4a-45c9-af21-98ad76e0d075 Co-authored-by: DocGarbanzo <47540921+DocGarbanzo@users.noreply.github.com>
DocGarbanzo
approved these changes
May 13, 2026
Agent-Logs-Url: https://github.com/DocGarbanzo/donkeycar/sessions/3630ed81-15c9-4069-962d-2e4fd408c04a Co-authored-by: DocGarbanzo <47540921+DocGarbanzo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/DocGarbanzo/donkeycar/sessions/3630ed81-15c9-4069-962d-2e4fd408c04a Co-authored-by: DocGarbanzo <47540921+DocGarbanzo@users.noreply.github.com>
…Keras 3 stub Agent-Logs-Url: https://github.com/DocGarbanzo/donkeycar/sessions/897c325a-e9ac-4052-8e61-9d5b897c4b87 Co-authored-by: DocGarbanzo <47540921+DocGarbanzo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_legacy_adam_class()returns non-None in Keras 3 because attribute access succeeds, but instantiation raisesImportError_legacy_adam_class()to probe actual instantiation so it returnsNonein Keras 3 environments (no Metal)