Refactor/modules and add tests for counters#57
Merged
Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Pull request overview
This PR refactors src/index.js by extracting configuration loading, node health-check logic, and request/health statistics into dedicated modules, and adds Jest coverage for the new counters implementation.
Changes:
- Extract YAML config loading into
src/config.jsand replace inline config parsing insrc/index.js. - Move node probing / health-check logic into
src/health-check.jsand wire it into the request flow. - Introduce
src/counters.jsfor centralized statistics (with mutex-guarded updates) and add Jest tests for it.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.js | Switches to loadConfig, Counters, and createGetServerData to reduce inline logic and centralize stats updates. |
| src/health-check.js | New module encapsulating node probing (version + jussi checks) and counter updates. |
| src/counters.js | New counters/state container (per-node maps + totals + RPS window) with async-mutex protection. |
| src/config.js | New helper to load YAML config and expand ${ENV_VAR} placeholders. |
| js_tests/counters.test.js | Adds unit tests for the new Counters module behavior. |
| README.md | Adds Docker Hub badges. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.