fix: Move npm registry config from .nvmrc to .npmrc #348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.nvmrc
to only contain the Node.js version (v22
).npmrc
where it belongs.claude/
to.gitignore
Problem
The current
.nvmrc
file contains npm registry configuration, which causes errors with version managers likemise
:This happens because
.nvmrc
should only contain a Node.js version string, not npm configuration.Background
The
.nvmrc
file has historically contained npm registry configuration, which is incorrect. This was originally added in #158 and has required workarounds.The publish workflow has been working around this issue by stripping out registry lines with
sed -i "/@doist/d" ./.nvmrc
(see publish.yml:17).Changes
.nvmrc
: Removed@doist:registry=https://npm.pkg.github.com/
line.npmrc
: Created new file with the registry configuration (proper location).gitignore
: Added.claude/
to ignore Claude Code settingsRelated
.nvmrc
: chore: Add publishing to GitHub package registry #158 (PR by @pawelgrimm)🤖 Generated with Claude Code