Skip to content

chore: add MIT license, CRLibre acknowledgments, Dojo Coding branding & code review#16

Merged
dbejarano820 merged 3 commits intomainfrom
chore/docs-licensing-acknowledgments
Feb 22, 2026
Merged

chore: add MIT license, CRLibre acknowledgments, Dojo Coding branding & code review#16
dbejarano820 merged 3 commits intomainfrom
chore/docs-licensing-acknowledgments

Conversation

@dbejarano820
Copy link
Contributor

Changes

📄 License & Branding

  • Add MIT LICENSE file
  • Add license, author, repository, homepage fields to all package.json files
  • Add Acknowledgments section referencing CRLibre/API_Hacienda — the pioneering PHP open-source API for Costa Rica electronic invoicing
  • Add Powered by Dojo Coding footer to README
  • Fix CI badge URL (was pointing to wrong GitHub org)

🔍 Code Review

  • Full code review findings documented in CODE_REVIEW.md
  • 623 tests passing, all 4 packages build successfully
  • 8 issues identified (2 critical for npm publish, 3 medium, 3 low)

📦 npm Publish Readiness

To go live on npm, two manual steps remain:

  1. Create @hacienda-cr org on npmjs.com
  2. Add NPM_TOKEN GitHub secret

See CODE_REVIEW.md for full checklist.

- Add LICENSE file (MIT)
- Add license, author, repository fields to all package.json files
- Add Acknowledgments section referencing CRLibre/API_Hacienda
- Add Powered by Dojo Coding footer
- Fix CI badge URL (danielbejarano → DojoCodingLabs)
@greptile-apps
Copy link

greptile-apps bot commented Feb 22, 2026

Greptile Summary

This PR adds critical npm publish infrastructure (MIT LICENSE file, package.json metadata) and comprehensive documentation (CODE_REVIEW.md with 8 issues identified, CRLibre acknowledgments, Dojo Coding branding). All changes are documentation and metadata only - no code logic modified.

Key additions:

  • MIT LICENSE file resolving critical npm publish blocker
  • license, author, repository, homepage fields in all 5 package.json files
  • Acknowledgments section crediting CRLibre/API_Hacienda PHP library
  • Dojo Coding footer and corrected CI badge URL
  • CODE_REVIEW.md documenting 623 passing tests, 2 critical (npm org creation, NPM_TOKEN), 3 medium, and 3 low severity issues

Minor issue found:

  • CODE_REVIEW.md date shows "2025-02-22" instead of "2026-02-22"

Confidence Score: 4/5

  • Safe to merge - documentation and metadata changes only, with one minor date typo
  • All changes are non-functional (LICENSE, package.json metadata, README acknowledgments, CODE_REVIEW.md). The only issue is a typo in the review date (2025 vs 2026). No code logic modified, builds/tests unaffected.
  • CODE_REVIEW.md - contains incorrect date (2025 instead of 2026)

Important Files Changed

Filename Overview
LICENSE Standard MIT License added with Dojo Coding Labs copyright - addresses critical npm publish blocker
CODE_REVIEW.md Comprehensive code review document added - date shows "2025-02-22" which appears to be a future date
README.md Added acknowledgments to CRLibre, Dojo Coding footer, and fixed CI badge URL to point to DojoCodingLabs org
package.json Added license, author, repository, and homepage metadata fields for npm compliance
packages/cli/package.json Added license, author, repository with directory, and homepage metadata for npm publish
packages/mcp/package.json Added license, author, repository with directory, and homepage metadata for npm publish
packages/sdk/package.json Added license, author, repository with directory, and homepage metadata for npm publish
shared/package.json Added license, author, repository with directory, and homepage metadata for npm publish

Last reviewed commit: 96f9a52

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link

greptile-apps bot commented Feb 22, 2026

Additional Comments (1)

CODE_REVIEW.md
Date shows "2025-02-22" but today is 2026-02-22

**Date:** 2026-02-22  
Prompt To Fix With AI
This is a comment left during a code review.
Path: CODE_REVIEW.md
Line: 3

Comment:
Date shows "2025-02-22" but today is 2026-02-22

```suggestion
**Date:** 2026-02-22  
```

How can I resolve this? If you propose a fix, please make it concise.

@dbejarano820 dbejarano820 merged commit 34fd110 into main Feb 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant