chore: improve CLAUDE.md with architecture and conventions#21
Merged
dbejarano820 merged 2 commits intomainfrom Feb 22, 2026
Merged
chore: improve CLAUDE.md with architecture and conventions#21dbejarano820 merged 2 commits intomainfrom
dbejarano820 merged 2 commits intomainfrom
Conversation
Add missing SDK modules (config, tax, logging), shared package structure, build/test details (tsup, Vitest, Turbo caching), coding conventions (type imports, ESM-only, test naming), and updated dependencies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Greptile SummaryThis PR adds a comprehensive Key improvements:
Minor issue found:
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| CLAUDE.md | Comprehensive documentation file with accurate architecture details and conventions; minor issue with export count claim |
Last reviewed commit: 33ec845
| | `tax/` | Tax calculation: rounding, line items, IVA math | | ||
| | `logging/` | Structured logger with levels (DEBUG→SILENT), text/JSON output | | ||
|
|
||
| Each module uses barrel exports via `index.ts`. The SDK root `src/index.ts` re-exports 190+ symbols organized by domain. |
There was a problem hiding this comment.
The claim of "190+ symbols" appears overstated. Based on packages/sdk/src/index.ts, there are significantly fewer exported symbols (approximately 80-100 when counting all named exports, types, and re-exports). Consider updating to a more accurate count or removing the specific number.
Prompt To Fix With AI
This is a comment left during a code review.
Path: CLAUDE.md
Line: 58
Comment:
The claim of "190+ symbols" appears overstated. Based on `packages/sdk/src/index.ts`, there are significantly fewer exported symbols (approximately 80-100 when counting all named exports, types, and re-exports). Consider updating to a more accurate count or removing the specific number.
How can I resolve this? If you propose a fix, please make it concise.Run Prettier on CLAUDE.md to fix formatting. Add husky + lint-staged so Prettier runs automatically on all staged files before every commit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
consistent-type-imports,_prefix for unused vars, ESM-only, test naming patternshaciendacostarica-signerreference with actual signing stack (xadesjs,xmldsigjs,node-forge)Test plan
🤖 Generated with Claude Code