feat(manufacturers): **Logos for vendors** logo-aware UI and label workflows (core, no bundled assets) by akira69 · Pull Request #857 · Donkie/Spoolman

akira69 · 2026-02-22T15:42:17Z

Summary

This PR adds logo-aware manufacturer workflow and logo-aware label behavior

Totally awesome looking logo-filled labels can now be printed/exported

Scope Boundary

Included here:

manufacturer logo fields/previews and local runtime logo usage
logo-aware spool/filament show pages
logo-aware spool/filament print flows
logo-aware spool/filament export flows
legacy-state hardening needed so the stacked logo flows still load on older saved settings/state

Not included here:

GitHub logo-pack sync workflow (follow-up stacked PR feat(vendors/logos): add GitHub logo-pack sync workflow (no bundled assets) #872 )
bundled vendor logo assets in this repository
OS print dialog or physical paper-alignment certification

Stack Notes

Verified against open PR #857 on branch feat/manufacturer-logo-upstream-split targeting master
Verified lower PR heads referenced for the stack:
- #846 head 4dd7808
- #860 head 4caa688
Those lower heads are not literal ancestors of the current #857 branch anymore, so the remaining shared fixes were carried forward directly here
The intended stacking order to get the full feature set of labels and logos is :

Screenshots and Visual Impact

Logos can be uploaded/defined on the manufacturer edit page and Black and White Print Logos can be auto-generated from Color source, or separately uploaded

Improved layout of spool page to incorporate the logos with hyperlink to the filament

Incorporation of separate logo section with individual controls using logo defined in manufacturing page (link or B&W converted print logo)

Separated label layout controls for QR code and information, with again individual controls

###Filtering enabled in Manufacturer section for those with or without logos

Validation Executed

Built and tested

cd client && VITE_APIURL=/api/v1 npm run build
Playwright validation on local PR857 app at http://127.0.0.1:9857

Playwright routes exercised in this pass:

/settings
/vendor/edit/1
/vendor/show/1
/spool/show/1 at desktop width
/spool/show/1 at mobile width
/filament/show/1
/spool/print?spools=1
/filament/print?filaments=1
/spool/export?spools=1
/filament/export?filaments=1
/vendor

Export download actions exercised in this pass:

spool export: AML download
spool export: PNG download
filament export: AML download

Test Checklist

Testing exposed issues and resulting fixes incorporated:

harden label printing/export against legacy plain-string base_url settings and bad saved local state
restore the spool show-page manufacturer/logo section with responsive desktop/mobile layout
wire the shared QR print and export dialogs to render manufacturer logo, title, and info blocks for both spool and filament flows

Notes

The local Playwright seed data for this pass used one manufacturer with both web and print logos plus one linked filament/spool record so the print/show/export routes exercised real logo rendering.
The local settings database was seeded with a plain-string base_url to confirm the carried-forward compatibility fix on settings, print, and export routes.
Downloaded export artifacts were inspected after Playwright capture: spool AML (~47 KB), spool PNG (471x353, ~33 KB), and filament AML (~45 KB).

Donkie · 2026-02-24T07:03:31Z

Are you vibe coding all these changes? Do you test them thoroughly?

I don't want to host any companies IP. We cannot have vendor logos in this repository.

akira69 · 2026-02-24T08:05:11Z

Are you vibe coding all these changes? Do you test them thoroughly?

I don't want to host any companies IP. We cannot have vendor logos in this repository.

First thing I'm doing here is breaking down the few of PRs I had made to individual and separated changes/features, to not overload review or testing- hence you'll see all the new PRs (draft) all of which need to be retested separately - this logo one included with non direct logo relevant changes moved to other PRs. I had to rely heavily on vibe coding to implement the featues quickly, so testing and review by humans will be essential - and hopefully much easier with the separated PRs. Prior to the PR simplification, I made tons of zip files and AML files, etc - all with various logos and styles. However I certainly didn't check all the corner cases of label sizing, etc - that's a to-do.

I agree with your point on the Logo files in the repository - In this implementation, vendor logos can be synced to the user's installation from https://github.com/MarksMakerSpace/filament-profiles upon click, by the user - not in this repository or hosted in this repository - at least that was my intention.
Nothing should be directly in this repository in this manner. Upon implementing this feature one could skip the sync and have no logos... or their own logos... or choose to sync with the github database mentioned, for those manufacturers created in the local database.

akira69

I don't want to host any companies IP. We cannot have vendor logos in this repository.

@Donkie,
Images are now completely out - I realized it was grabbing all the files into this repository too, unintended. That's explicitly removed. And then some to reduce complexity of each change PR. As I noted earlier, I've split apart the large PRs into bite-size chunks and individual improvements.
And went even further with this now Logo specific PR: Splitting into two separate PR with different logo focus:
this PR #857 to build up all the infrastructure for logos. allowing HTML links to image files. and local files. Along with the improvements to print/export of label-aware labels with adjustable details.
then separately PR #872 for the sync with GitHub repository for logos.

I'm still testing many of the PRs and improving the comments/details, including this one. will get them squared away soon.

- Extract _build_search_filters() helper to reduce McCabe complexity - Reduces find() complexity from 13 → ~8 (under 10 limit) - Reduces branch count from 13 → acceptable levels - Resolves Ruff linting errors C901 + PLR0912 - Pure refactoring: behavior unchanged - Also fixes Prettier formatting on filamentSelectModal and qrCodePrintingDialog

- Wrap selectUnselectFiltered, handleSelectItem callbacks in useCallback - Wrap handlePageChange, handlePageSizeChange, applySearchFilter in useCallback - Reduces unnecessary re-renders of child components (pagination, checkboxes, buttons) - Stable function references now persist across renders

…ack PR773) - Fetch extra field definitions once at endpoint entry instead of per-request - Eliminates redundant database calls for extra field validation - Applies feedback from PR 773: 'get_extra_fields only needs to be run max at once per call' - Affected endpoints: create/update for filament, spool, and vendor resources - Reduces API layer complexity and improves performance

(cherry picked from commit dc11b7bdae1777a70a68bedfe503f988e96acd13)

…ase URL handling Harden QR export base URL parsing to prevent template injection attacks Per https://github.com/Donkie/Spoolman/wiki/Contribute#style - ESLint (frontend) ✓ Fixed: control character regex - Prettier (frontend) ✓ Fixed: 7 files formatting - Ruff (backend) ✓ - Pre-commit hooks validated ✓

- Wrap selectUnselectFiltered, handleSelectItem callbacks in useCallback - Reduces unnecessary re-renders of table and checkboxes - Consistent with filament selector optimization pattern - Stable function references improve React.memo effectiveness

…export - Add manufacturer logo management (upload, delete, organization) - Integrate logos into label print dialogs (positioning, sizing) - Add vendor logo components and utilities - Support logo source toggle (color/print profile) - Add i18n strings for logo UI elements - Extend vendor database with logo support This commit layers vendor logo features on top of the export workflow. All export functionality is preserved; logos are optional additions to print/export dialogs.

- Use single debounced ?search= call, consistent with spool modal and PR846 - Remove 4-field parallel fetch loop, getAPIURL import, allSearchResults state - Fix Ruff violations in vendor.py and vendor_logos.py

- Add useSpoolmanVendorExternalIds and useVendorLogoManifest to otherModels - Declare and forward extraTitleSettings/extraInfoSettings in QRCodePrintingDialog - Add initialSelectedIds, onExport props and Export button to FilamentSelectModal

- qrCodePrintingDialog: 5 spread fixes (identical to PR846) - filamentQrCodePrintingDialog: 4 spread fixes (3 original + titleTemplate) - spoolQrCodePrintingDialog: 4 spread fixes (same as filament) - qrCodeExportDialog: 5 spread fixes (identical to PR860) - spoolSelectModal: selectedSet useMemo + .has() for O(1) checks - exportDialog: move PNG helpers to module scope (same as PR860)

akira69 mentioned this pull request Feb 22, 2026

feat(printing): filament label printing foundation #846

Open

11 tasks

akira69 force-pushed the feat/manufacturer-logo-upstream-split branch from 81b4f74 to e61f2ad Compare February 22, 2026 15:45

akira69 mentioned this pull request Feb 22, 2026

fix(custom-fields): align #773 filter/sort with current master #858

Closed

akira69 force-pushed the feat/manufacturer-logo-upstream-split branch from e61f2ad to 0419ce3 Compare February 22, 2026 16:01

akira69 changed the title ~~feat(vendors/labels): manufacturer logo workflows and logo-pack tooling~~ feat(vendors): logo pack sync + logo-aware label workflows Feb 22, 2026

akira69 marked this pull request as ready for review February 23, 2026 16:43

This was referenced Feb 23, 2026

QR code size is changed by each label #829

Open

Labels: smaller margins on the QR codes #794

Open

Labelprinter #294

Open

Additional Label Formatting Capabilities #685

Open

akira69 marked this pull request as draft February 24, 2026 04:48

akira69 added 2 commits February 23, 2026 23:11

feat(printing): add filament label printing foundation

1861cbb

docs: add changelog entry for printing updates

9e4cf60

akira69 force-pushed the feat/manufacturer-logo-upstream-split branch 2 times, most recently from eaf2375 to 8d294ac Compare February 24, 2026 06:56

perf(printing): paginate filament selector and clarify print page titles

dcfc8e7

akira69 force-pushed the feat/manufacturer-logo-upstream-split branch from 8d294ac to 58761ad Compare February 25, 2026 23:23

i18n(printing): use explicit filament/spool print page titles

b9432d0

akira69 force-pushed the feat/manufacturer-logo-upstream-split branch from 58761ad to 4f03ada Compare February 26, 2026 13:15

akira69 changed the title ~~feat(vendors): logo pack sync + logo-aware label workflows~~ feat(vendors): logo-aware label workflows (core, no bundled assets) Feb 26, 2026

akira69 mentioned this pull request Feb 26, 2026

feat(vendors/logos): add GitHub logo-pack sync workflow (no bundled assets) #872

Open

22 tasks

akira69 force-pushed the feat/manufacturer-logo-upstream-split branch 2 times, most recently from f091b0e to f4f6564 Compare February 26, 2026 16:31

akira69 commented Feb 27, 2026

View reviewed changes

akira69 changed the title ~~feat(vendors): logo-aware label workflows (core, no bundled assets)~~ feat(manufacturers): **Logos for vendors** logo-aware UI and label workflows (core, no bundled assets) Mar 2, 2026

akira69 marked this pull request as ready for review March 2, 2026 05:07

akira69 closed this Mar 2, 2026

akira69 reopened this Mar 2, 2026

akira69 force-pushed the feat/manufacturer-logo-upstream-split branch from af29177 to 51204c5 Compare March 10, 2026 06:18

akira69 mentioned this pull request Mar 11, 2026

Need export labels to SVG-file format and PDF (or HTML) #730

Closed

akira69 force-pushed the feat/manufacturer-logo-upstream-split branch 2 times, most recently from b555eaa to 9eddfa1 Compare March 13, 2026 22:11

akira69 mentioned this pull request Mar 13, 2026

[Review Stack] #857 on #860 akira69/Spoolman_Labels#6

Open

akira69 marked this pull request as draft March 14, 2026 07:00

akira69 force-pushed the feat/manufacturer-logo-upstream-split branch 2 times, most recently from 0c959fa to 8a294cd Compare March 16, 2026 20:48

akira69 added 10 commits March 16, 2026 21:33

feat(export): add separate AML/PNG label export flows and improvements

012b8f3

docs(export): clarify PR 860 label export comments

476c269

Harden export dialog preset recovery

58a5045

Carry filament search foundation into export flow

2ab3e4a

Harden QR dialog base URL parsing

db85224

(cherry picked from commit dc11b7bdae1777a70a68bedfe503f988e96acd13)

akira69 force-pushed the feat/manufacturer-logo-upstream-split branch from e5873c9 to f20897d Compare March 17, 2026 02:56

fix: unified search param for filament modal + Ruff violations

d127692

- Use single debounced ?search= call, consistent with spool modal and PR846 - Remove 4-field parallel fetch loop, getAPIURL import, allSearchResults state - Fix Ruff violations in vendor.py and vendor_logos.py

akira69 force-pushed the feat/manufacturer-logo-upstream-split branch from 6f61439 to d127692 Compare March 17, 2026 13:17

akira69 added 2 commits March 18, 2026 11:47

akira69 marked this pull request as ready for review March 19, 2026 14:43

akira69 added 2 commits March 27, 2026 15:57

fix(printing): carry forward legacy-state logo fixes

a5a892e

feat(export): carry forward logo-aware label rendering

6ef61bd

This was referenced Mar 30, 2026

feat(export): add separate AML/PNG label export flows and improvements #860

Open

(discussion) : Features and ideas Fire-Devils/filaman-system#32

Closed

akira69 mentioned this pull request Apr 18, 2026

feat: advanced label designer for spool print page akira69/filaman-system#14

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(manufacturers): Logos for vendors logo-aware UI and label workflows (core, no bundled assets)#857

feat(manufacturers): Logos for vendors logo-aware UI and label workflows (core, no bundled assets)#857
akira69 wants to merge 20 commits intoDonkie:masterfrom
akira69:feat/manufacturer-logo-upstream-split

akira69 commented Feb 22, 2026 •

edited

Loading

Uh oh!

Donkie commented Feb 24, 2026

Uh oh!

akira69 commented Feb 24, 2026

Uh oh!

akira69 left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

akira69 commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Totally awesome looking logo-filled labels can now be printed/exported

Scope Boundary

Stack Notes

Screenshots and Visual Impact

Logos can be uploaded/defined on the manufacturer edit page and Black and White Print Logos can be auto-generated from Color source, or separately uploaded

Improved layout of spool page to incorporate the logos with hyperlink to the filament

Incorporation of separate logo section with individual controls using logo defined in manufacturing page (link or B&W converted print logo)

Separated label layout controls for QR code and information, with again individual controls

Validation Executed

Built and tested

Playwright routes exercised in this pass:

Export download actions exercised in this pass:

Test Checklist

Testing exposed issues and resulting fixes incorporated:

Notes

Uh oh!

Donkie commented Feb 24, 2026

Uh oh!

akira69 commented Feb 24, 2026

Uh oh!

akira69 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

akira69 commented Feb 22, 2026 •

edited

Loading

akira69 left a comment •

edited

Loading