Skip to content

UI: rename (✏️ Hide Columns) button to (✏️ Columns)#867

Open
akira69 wants to merge 1 commit intoDonkie:masterfrom
akira69:feat/ui-columns-button-label-upstream-split
Open

UI: rename (✏️ Hide Columns) button to (✏️ Columns)#867
akira69 wants to merge 1 commit intoDonkie:masterfrom
akira69:feat/ui-columns-button-label-upstream-split

Conversation

@akira69
Copy link
Copy Markdown

@akira69 akira69 commented Feb 24, 2026

Summary

  • Rename the list-table column toggle button label from "✏️Hide Columns" to "✏️Columns"
  • keeps behavior unchanged; this clarifies that this control button toggles both show and hide - at first glance to this UI it was not clear to me. Hence this improvement.

Visualization

Old:
image
New:
image

Scope

  • text-only UI clarification
  • no backend changes
  • no table behavior changes
  • across all languages

Scope Mapping

  • No dedicated upstream issue link or feature request was found for this improvement

Code Quality Compliance ✅

Per https://github.com/Donkie/Spoolman/wiki/Contribute#style

  • ESLint (frontend): N/A - i18n changes only
  • Prettier (frontend) ✓
  • Ruff (backend): N/A
  • Pre-commit hooks validated ✓

Note on Locale File Edits

Locale file edits typically go through Weblate to coordinate with community translations.
This PR is an exception: it's a UI string consolidation (removing "Hide" verb) rather than translation work. Future translation changes should use Weblate workflow.

Testing Performed

  • Built frontend (npm ci && npm run build) and confirmed no build/type errors.
  • Rebuilt PR UI: rename (✏️ Hide Columns) button to (✏️ Columns) #867 Docker image and redeployed a specific container along with spoolmanDB data.
  • Verified button change across all pages (English) and button function
  • Changed language to de and cs to confirm change on one page

Untested

  • All languages across all pages (should not be necessary...)

Localization and Languages Details:

This PR updates only one key in each locale file:

  • buttons.hideColumns: changed from a "Hide Columns" phrase to a simplified "Columns" label.

Updated locales (exact old → new):

  • cs: Skrýt sloupceSloupce
  • da: Skjul kolonnerKolonner
  • de: Spalten ausblendenSpalten
  • el: Απόκρυψη ΣτηλώνΣτήλες
  • en: Hide ColumnsColumns
  • es: Ocultar ColumnasColumnas
  • et: Peida tulbadTulbad
  • fa: مخفی کردن ستونستونها
  • fr: Masquer les colonnesColonnes
  • hu: Oszlopok elrejtéseOszlopok
  • it: Nascondi ColonnaColonne
  • ja: コラムを隠す
  • lt: Slėpti stulpeliusStulpeliai
  • nb-NO: Skjul kolonnerKolonner
  • nl: Kolommen verbergenKolommen
  • pl: Edytuj kolumnyKolumny
  • pt: Ocultar ColunasColunas
  • pt-BR: Ocultar ColunasColunas
  • ro: ascunde coloaneColoane
  • ru: Скрыть столбцыСтолбцы
  • sv: Dölj kolumnerKolumner
  • ta: நெடுவரிசைகளை மறைக்கவும்நெடுவரிசைகள்
  • th: ซ่อนคอลัมน์คอลัมน์
  • tr: Sütunları gizleSütunlar
  • uk: Приховати СтовпціКолонки
  • zh: 隐藏列
  • zh-Hant: 隱藏欄

Translation Coordination with #825

  • This PR overlaps upstream #825 in shared locale files.
  • Overlap is limited to translation JSON files.
  • If #825 merges first:
    • rebase #867 and re-apply the simplified buttons.hideColumns → Columns wording in overlapping locales.
  • If #867 merges first:
    • rebase #825 and preserve any unrelated Weblate translation updates while keeping the Columns wording where conflicts occur.
  • Expected conflict scope is locale-string reconciliation only; no code or behavior conflict.

@akira69 akira69 changed the title UI: rename Hide Columns button to Columns ✏️ UI: rename Hide Columns button to Columns Feb 24, 2026
@akira69 akira69 changed the title ✏️ UI: rename Hide Columns button to Columns UI: rename (✏️ Hide Columns) button to (✏️ Columns) Feb 24, 2026
@akira69 akira69 force-pushed the feat/ui-columns-button-label-upstream-split branch from aef27e9 to 7aaaa01 Compare February 24, 2026 17:09
@akira69 akira69 marked this pull request as ready for review February 24, 2026 17:24
@akira69 akira69 marked this pull request as draft February 26, 2026 16:47
@akira69 akira69 marked this pull request as ready for review February 26, 2026 17:12
@akira69 akira69 closed this Mar 2, 2026
@akira69 akira69 reopened this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant