fix: address custom field review feedback for PR 773#893
Draft
akira69 wants to merge 8 commits intoDonkie:masterfrom
Draft
fix: address custom field review feedback for PR 773#893akira69 wants to merge 8 commits intoDonkie:masterfrom
akira69 wants to merge 8 commits intoDonkie:masterfrom
Conversation
This was referenced Mar 26, 2026
daften
added a commit
to daften/Spoolman
that referenced
this pull request
Mar 29, 2026
…e filter/sort - Add comprehensive tests covering all 9 field types (text, integer, float, boolean, single-choice, multi-choice, datetime, integer_range, float_range) for filter and sort on spool, filament, and vendor entities - Add invalid-filter 400 tests for float, integer_range, and float_range - Fix integer_range/float_range filter to use LIKE pattern matching against Python's deterministic json.dumps output instead of fragile .contains() - Add integer_range/float_range sort support via a @compiles helper (_JsonArrayFirstElement) that emits CAST(col AS JSON)->>0 on PostgreSQL and JSON_EXTRACT(col, '$[0]') on SQLite/MariaDB - Add logger and __all__ to extra_fields.py (aligns with PR Donkie#893) - All tests verified passing on postgres, sqlite, and mariadb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This is a helper PR for #773, not an attempt to replace @daften's PR thread.
The goal here is to make the requested review fixes easy to inspect and cherry-pick.
Commits
Includes
Notes
This branch is intended to support cherry-picking into PR 773
I posted per-thread replies on PR 773 pointing back to these commits
I verified it locally against the same CI command paths that are red on PR 773:
uv run lefthook run ciforstyle(Ruff, format check, ESLint, Prettier)cd client && rm -f .env .env.production && echo "VITE_APIURL=/api/v1" > .env.production && npm run buildforbuild-clientIf @daften wants to cherry-pick directly, the commands are:
git fetch https://github.com/akira69/Spoolman_Labels feat/pr773-review-feedback
git cherry-pick 9711495 3208f8d 9abd208 cb62dd6