swing port#1076
Closed
bearrrrrrrr wants to merge 2 commits into
Closed
Conversation
Member
|
I've assigned @carda-sometimesknownas-paxilmaniac to this one, as they are the original codewriter back on Lethal. I've heard concerns that this might not work well with how we are a TG downstream, but unfortunately that's a little outside of my knowledge. |
Member
|
Hey @bearrrrrrrr For this system to work well here it would need an entire top-down rework into being individual elements. Raw porting it from Lethal is unfortunately not on the cards for this one. After speaking with the Maintainer team, we think its for the best to go ahead and close the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
direct 1:1 port of LethalStation#14
Why It's Good For The Game
anything that makes tg combat play less like it does is probably a good idea
Testing Evidence
atm it's not on any weapons except the test weapon(s) but it does indeed work
Changelog
🆑
add: port of swing combat
/:cl: