Skip to content

Conversation

@bjornhellander
Copy link
Contributor

@bjornhellander bjornhellander commented Jan 21, 2024

Partly fixes #3781.
Handles originally reported case (overrides), but not the case of implementing an interface.

Updated to fix the issue completely.

Fixes #3781

@codecov
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

❌ Patch coverage is 98.91304% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.45%. Comparing base (f5843ae) to head (1e60541).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #3782    +/-   ##
========================================
  Coverage   97.44%   97.45%            
========================================
  Files         926      931     +5     
  Lines      110283   110679   +396     
  Branches     3319     3327     +8     
========================================
+ Hits       107467   107859   +392     
- Misses       1847     1850     +3     
- Partials      969      970     +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bjornhellander
Copy link
Contributor Author

Any comments on this, @sharwell?

…CorrectCasing unless a diagnostic will be issued
@bjornhellander bjornhellander force-pushed the sa1316-member-override branch from 6f94c20 to 7ea2d3f Compare March 23, 2024 07:48
…r's signature, if that member is an override or implements an interface

DotNetAnalyzers#3781
@bjornhellander bjornhellander force-pushed the sa1316-member-override branch from 7ea2d3f to d1b6183 Compare March 23, 2024 07:59
@bjornhellander
Copy link
Contributor Author

Rebased and updated to also handle members implemented from an interface, making it a complete fix for the linked issue.
Also moved a string allocation to make it not occur as often.

Ready for review.

@sharwell
Copy link
Member

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sharwell sharwell merged commit c369e44 into DotNetAnalyzers:master Nov 21, 2025
21 checks passed
@sharwell sharwell added this to the 1.2-beta.next milestone Nov 21, 2025
@bjornhellander bjornhellander deleted the sa1316-member-override branch November 29, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SA1316: Inactionable diagnostic in method overrides

2 participants