Add initial code #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add initial code * remove test pypi * exit publish if not on main * add test pypi * install stubs * fix dependency instllation * naming of ci
ldeichmann
reviewed
Apr 2, 2025
| proxy: httpx.Proxy | None = None, | ||
| ) -> None: | ||
| with httpx.stream('GET', url, follow_redirects=True, proxy=proxy) as response: | ||
| total = int(response.headers['Content-Length']) |
There was a problem hiding this comment.
If the transport is using http/1.1 and the transfer-encoding is chunked, there is no content-length - case needs to be handled
ldeichmann
reviewed
Apr 2, 2025
| PROXY = ProxyType() | ||
|
|
||
|
|
||
| def _download_to_stream( |
There was a problem hiding this comment.
Why doesn't this use the download_to_stream function defined in _download? It seems like this should only exist once and progress can be controlled via a callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.