Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RUF012 #156 #248

Merged
merged 4 commits into from
Sep 6, 2023
Merged

fix RUF012 #156 #248

merged 4 commits into from
Sep 6, 2023

Conversation

leon1995
Copy link
Member

@leon1995 leon1995 commented Aug 31, 2023

part of linting fix #156 . this fixes RUF012

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the changelog accordingly.
  • I have added tests to cover my changes.

@leon1995 leon1995 added the enhancement New feature or request label Aug 31, 2023
@leon1995 leon1995 self-assigned this Aug 31, 2023
@leon1995
Copy link
Member Author

one can check for all occurrences of RUF102 using ruff check . --select RUF012

@leon1995 leon1995 added the v2 Version 2 is affected label Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (20669bd) 88.35% compared to head (c8756ee) 88.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   88.35%   88.35%           
=======================================
  Files         112      112           
  Lines       13223    13227    +4     
=======================================
+ Hits        11683    11687    +4     
  Misses       1540     1540           
Files Changed Coverage Δ
src/sdc11073/provider/providerimpl.py 93.21% <ø> (ø)
src/sdc11073/definitions_base.py 94.73% <100.00%> (ø)
src/sdc11073/definitions_sdc.py 100.00% <100.00%> (ø)
src/sdc11073/httpserver/compression.py 89.61% <100.00%> (-0.27%) ⬇️
src/sdc11073/mdib/consumermdibxtra.py 75.86% <100.00%> (ø)
src/sdc11073/mdib/descriptorcontainers.py 96.52% <100.00%> (ø)
src/sdc11073/mdib/statecontainers.py 97.28% <100.00%> (ø)
src/sdc11073/provider/porttypes/porttypebase.py 96.39% <100.00%> (ø)
src/sdc11073/pysoap/soapenvelope.py 95.74% <100.00%> (ø)
src/sdc11073/wsdiscovery/wsdimpl.py 88.17% <100.00%> (+0.06%) ⬆️
... and 9 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon1995 leon1995 requested review from a-kleinf and deichmab-draeger and removed request for deichmab-draeger and a-kleinf September 4, 2023 09:49
# Conflicts:
#	src/sdc11073/xml_types/basetypes.py
@leon1995 leon1995 merged commit 1240d2b into Draegerwerk:master Sep 6, 2023
@leon1995 leon1995 deleted the lint/RUF012 branch September 6, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2 Version 2 is affected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: fix linting problems
2 participants