Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TID252 #270

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix TID252 #270

merged 1 commit into from
Oct 5, 2023

Conversation

leon1995
Copy link
Member

@leon1995 leon1995 commented Oct 5, 2023

fixes TID252

can be verified with ruff check . --select TID252

#156

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the changelog accordingly.
  • I have added tests to cover my changes.

@leon1995 leon1995 added enhancement New feature or request v2 Version 2 is affected labels Oct 5, 2023
@leon1995 leon1995 self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (26bd75b) 89.63% compared to head (9d04520) 89.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files         113      113           
  Lines       13102    13102           
=======================================
  Hits        11744    11744           
  Misses       1358     1358           
Files Coverage Δ
src/sdc11073/dispatch/messageconverter.py 72.41% <100.00%> (ø)
src/sdc11073/dispatch/pathelementregistry.py 73.68% <100.00%> (ø)
src/sdc11073/httpserver/httprequesthandler.py 64.21% <100.00%> (ø)
src/sdc11073/httpserver/httpserverimpl.py 92.15% <100.00%> (ø)
src/sdc11073/provider/periodicreports.py 100.00% <100.00%> (ø)
...3/provider/porttypes/containmenttreeserviceimpl.py 100.00% <100.00%> (ø)
src/sdc11073/provider/porttypes/getserviceimpl.py 96.51% <100.00%> (ø)
...sdc11073/provider/porttypes/localizationservice.py 97.98% <100.00%> (ø)
src/sdc11073/provider/scopesfactory.py 86.48% <100.00%> (ø)
src/sdc11073/provider/subscriptionmgr.py 83.92% <100.00%> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon1995 leon1995 merged commit 1a5954a into Draegerwerk:master Oct 5, 2023
@leon1995 leon1995 deleted the fix/TID252 branch October 5, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2 Version 2 is affected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants