fix: waypoint visible from vanish players in spectator mode#77
Closed
NgLoader wants to merge 1 commit intoDrexHD:mainfrom
Closed
fix: waypoint visible from vanish players in spectator mode#77NgLoader wants to merge 1 commit intoDrexHD:mainfrom
NgLoader wants to merge 1 commit intoDrexHD:mainfrom
Conversation
DrexHD
added a commit
that referenced
this pull request
Nov 28, 2025
Owner
|
Thanks, I have improved the original mixin responsible for hiding vanished player waypoints! |
Contributor
Author
|
Thanks, yea thats a better way to hide waypoints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a player is in spectator mode, they can still see the vanished player in the waypoint bar.
I tested this on version 1.21.10.
We may need to review additional calls to
serverPlayer.isSpectator()to identify any other occurrences.Current version:
https://i.wuffy.eu/u/engkqr.gif
Fixed version:
https://i.wuffy.eu/u/dXZ3VJ.gif
I just tested this fix with two players!