Minimum viable product (Closes #11) #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually not so minor. SSE now works, REAL TIME updates achieved (race condition here we come). Also there is lots of cleaning needing to be done. PLease contanct Simon Mechler for tidying services :D
TODO: Fix full/partial schemas, add/remove pubs/themes/keys, secure sse, add queue status (maybe), styling
Some big issues needs to be fixed before the MVP is complete. The smaller ones and styling will be left for further development
Improve development guide
Fiery-132
approved these changes
Apr 7, 2025
Comment on lines
26
to
28
| if (cookies.get("adminKey") !== ADMIN_KEY) { | ||
| return fail(401, { message: "Unauthorized" }); | ||
| } |
There was a problem hiding this comment.
Authorisation is performed on every action so maybe extract that to a separate function?
Comment on lines
+30
to
+45
| const formData = Object.fromEntries(await request.formData()); | ||
|
|
||
| const result = pubKeyIdPairSchema.pick({ | ||
| pubKey: true, | ||
| pubId: true, | ||
| }) | ||
| .safeParse(formData); | ||
|
|
||
| if (!result.success) { | ||
| const { fieldErrors } = result.error.flatten(); | ||
|
|
||
| return fail(400, { | ||
| errors: fieldErrors, | ||
| values: result.data, | ||
| }); | ||
| } |
There was a problem hiding this comment.
This sequence is also very repeated:
const formData = ...
const result = ...
if (!result.success) { ... }Perhaps make some kind of helper function like:
async function parseForm<T>(request: Request, schema: ZodSchema<T>) {
const formData = Object.fromEntries(await request.formData());
const result = schema.safeParse(formData);
if (!result.success) {
const { fieldErrors } = result.error.flatten();
return fail(400, { errors: fieldErrors, values: result.data });
}
return result.data;
}
Comment on lines
+27
to
+32
| const pubKey: PubKey = cookies.get("pubKey"); | ||
| const pubKeyIdPairs: PubKeyIdPairs = await getPubKeyIdPairs(); | ||
|
|
||
| if (!pubKey || !pubKeyIdPairs.has(pubKey)) { | ||
| return fail(401, { message: "Unauthorized" }); | ||
| } |
There was a problem hiding this comment.
I would probably extract this to avoid repetition. 😄
DEtta är bra Co-authored-by: Simon Mechler <[email protected]>
Sounds good to me Co-authored-by: Simon Mechler <[email protected]>
This is on you if it fails >:) Co-authored-by: Simon Mechler <[email protected]>
Sounds good, will implement before merging Co-authored-by: Simon Mechler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimum viable (barely) product finished. Issues on what needs to be done further will be created shortly.
Future work includes: