Skip to content

Wire up ESLint + Prettier, fix existing violations, add CI workflow#25

Merged
Du7chManiac merged 1 commit into
mainfrom
claude/fix-eslint-copilot-lGRUR
Apr 14, 2026
Merged

Wire up ESLint + Prettier, fix existing violations, add CI workflow#25
Du7chManiac merged 1 commit into
mainfrom
claude/fix-eslint-copilot-lGRUR

Conversation

@Du7chManiac
Copy link
Copy Markdown
Owner

  • Add root-level ESLint flat config (eslint.config.js) with:
    • Base JS recommended rules
    • Node globals for backend; browser globals for frontend
    • React + React-Hooks (rules-of-hooks, exhaustive-deps) for frontend
    • React-Refresh (warning) for Vite HMR safety
    • Vitest globals for test files
    • eslint-config-prettier to avoid stylistic rule conflicts
  • Add Prettier config (.prettierrc.json) matching existing code style
    (single quotes, semis, 2-space, 100-col) and .prettierignore for
    generated output (dist, public, drizzle, db files, lockfile)
  • Add lint/lint:fix/format/format:check scripts to root package.json
  • Install devDeps: eslint, @eslint/js, globals, eslint-plugin-react,
    eslint-plugin-react-hooks, eslint-plugin-react-refresh, prettier,
    eslint-config-prettier
  • Mark root package.json as "type": "module" so eslint.config.js loads
    without the ESM warning
  • Apply prettier --write across the repo (mechanical formatting only)
  • Fix the 11 pre-existing ESLint errors surfaced by the new config:
    • Prefix unused args with _ (Express error middleware, carrier adapter
      contract params) or drop unused catch bindings / imports
    • Escape apostrophes in JSX text with '
  • Add .github/workflows/ci.yml running lint, format:check, test, and
    build on PRs and pushes to main
  • Update .github/copilot-instructions.md to document the new commands
    (the previous note about eslint being unavailable is no longer true)

- Add root-level ESLint flat config (eslint.config.js) with:
  - Base JS recommended rules
  - Node globals for backend; browser globals for frontend
  - React + React-Hooks (rules-of-hooks, exhaustive-deps) for frontend
  - React-Refresh (warning) for Vite HMR safety
  - Vitest globals for test files
  - eslint-config-prettier to avoid stylistic rule conflicts
- Add Prettier config (.prettierrc.json) matching existing code style
  (single quotes, semis, 2-space, 100-col) and .prettierignore for
  generated output (dist, public, drizzle, db files, lockfile)
- Add lint/lint:fix/format/format:check scripts to root package.json
- Install devDeps: eslint, @eslint/js, globals, eslint-plugin-react,
  eslint-plugin-react-hooks, eslint-plugin-react-refresh, prettier,
  eslint-config-prettier
- Mark root package.json as "type": "module" so eslint.config.js loads
  without the ESM warning
- Apply prettier --write across the repo (mechanical formatting only)
- Fix the 11 pre-existing ESLint errors surfaced by the new config:
  - Prefix unused args with _ (Express error middleware, carrier adapter
    contract params) or drop unused catch bindings / imports
  - Escape apostrophes in JSX text with '
- Add .github/workflows/ci.yml running lint, format:check, test, and
  build on PRs and pushes to main
- Update .github/copilot-instructions.md to document the new commands
  (the previous note about eslint being unavailable is no longer true)
@Du7chManiac Du7chManiac merged commit b6e4a17 into main Apr 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants