-
Notifications
You must be signed in to change notification settings - Fork 3
Chart js2.8 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mahugnon
wants to merge
30
commits into
DuneSt:development
Choose a base branch
from
mahugnon:ChartJS2.8
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chart js2.8 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct demo link
Release v1.0.1: Use stylesheet from github
DataSets setOption: anOption to: value
Set stylesheet default colors Change forChartJs to convert pharo colors to rgb
Rename Char2dData to ChartData
Remove unused methods
I opened the demo and saw some problems:
This need to be addressed before we review the model. |
Yes, you're right Cyril. It has to be improved. We just worked on 2D plots and little bit 1D plots |
-create chartType1d to check if the chart is one dimenssion -resetBackgroundwithDataSize transform the background color to an array as 1d charts have array as background color
ChartJs 2.8 does not support BoxPlot directly |
add accessor using set option support block as color
I tried the demo and now it does not open anymore. Here is the error I get:
|
Bizare. I will look at that
Le jeu. 2 janv. 2020 à 11:44, CyrilFerlicot <[email protected]> a
écrit :
… I tried the demo and now it does not open anymore.
Here is the error I get:
UndefinedObject>>doesNotUnderstand: #new
ChartData>>resetBackgroundwithDataSize
[ :jsonMapWriter |
jsonMapWriter writeKey: #labels value: (xObjects collect: [ :aXObject | self labelFor: aXObject ]).
jsonMapWriter writeKey: #datasets value: self resetBackgroundwithDataSize ] in ChartData>>neoJsonOn: in Block: [ :jsonMapWriter | ...
[ block value: mapWriter ] in NeoJSONWriter>>writeStreamingDo: in Block: [ block value: mapWriter ]
NeoJSONWriter>>indentedDo:
NeoJSONWriter>>writeStreamingDo:
NeoJSONWriter>>writeMapStreamingDo:
ChartData>>neoJsonOn:
NeoJSONWriter>>nextPut:
ChartJsComponent>>printDiagramCreationOn:inDiv:
[ :s |
self printDiagramContextCreationOn: s inDiv: divId.
s cr.
self printDiagramCreationOn: s inDiv: divId ] in [ self data hasData
ifTrue: [ html div
class: #chartJsGraph;
with: [ canvas := html canvas id: #graph , divId.
self manageCallBackIn: html canvas: canvas inDiv: divId ].
self createIfNecessaryLegend: html inDiv: divId.
html
script:
(String
streamContents: [ :s |
self printDiagramContextCreationOn: s inDiv: divId.
s cr.
self printDiagramCreationOn: s inDiv: divId ]) ]
ifFalse: [ html div
class: 'mdl-alert mdl-alert__danger';
style: 'color: red; text-align: center; margin: auto;';
with: [ html text: 'No data to display' ] ].
self data hasTitle ifTrue: [ self renderTitleId: divId on: html ] ] in ChartJsComponent>>renderContentOn: in Block: [ :s | ...
String class(SequenceableCollection class)>>new:streamContents:
String class(SequenceableCollection class)>>streamContents:
[ self data hasData
ifTrue: [ html div
class: #chartJsGraph;
with: [ canvas := html canvas id: #graph , divId.
self manageCallBackIn: html canvas: canvas inDiv: divId ].
self createIfNecessaryLegend: html inDiv: divId.
html
script:
(String
streamContents: [ :s |
self printDiagramContextCreationOn: s inDiv: divId.
s cr.
self printDiagramCreationOn: s inDiv: divId ]) ]
ifFalse: [ html div
class: 'mdl-alert mdl-alert__danger';
style: 'color: red; text-align: center; margin: auto;';
with: [ html text: 'No data to display' ] ].
self data hasTitle ifTrue: [ self renderTitleId: divId on: html ] ] in ChartJsComponent>>renderContentOn: in Block: [ self data hasData...
BlockClosure>>renderOn:
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15?email_source=notifications&email_token=AF7H2SZHJAHMEKFLMNUQT7DQ3XASBA5CNFSM4JDB4JFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH6CJ2I#issuecomment-570172649>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7H2SZSUNQLIQMRNFTSDRLQ3XASBANCNFSM4JDB4JFA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We propose an update of ChartJs to 2.8 version of ChartJS