Fix table refs by making minify plugin run last (#630) #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xpqz
commented
Dec 5, 2025
xpqz
commented
- Minify plugin removes quotes around ids, which the table captioning regexes rely on to do forward references.
- Solution: reorder plugins to minify after captioning
- Add explicit table captioning texts to all configs
xpqz
commented
Dec 5, 2025
| position: bottom | ||
| reference_text: 'Table {index}' | ||
| caption_prefix: 'Table {index}:' | ||
| - minify: |
FionaDyalog
approved these changes
Dec 8, 2025
Contributor
FionaDyalog
left a comment
FionaDyalog
left a comment
There was a problem hiding this comment.
LGTM (built and checked locally)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.