Add missing version argument at lines 342 and 441 in ecco_download.py #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to the ECCO team for their hard work on this valuable package.
In ecco_access/ecco_download.py, the "version" argument was missing in two spots:
In defining ecco_podaac_download(), the call of download_files_wrapper() (at line 441) did not include the version parameter.
Similarly, in defining download_files_wrapper(), a call of download_file() (at line 342) was also missing the version parameter.
Note that this is the same issue as raised by @cspencerjones in Issue #105.
This pull request adds the missing version argument at both of these instances. This fixes the error below while trying to follow the Direct download over the internet (mode = ‘download’) section of the ECCOv4 Python tutorial:
which gives the error: