feat: Redis Cluster support and global event deduplication#368
Open
Vvictor-commits wants to merge 1 commit intoEDOHWARES:mainfrom
Open
feat: Redis Cluster support and global event deduplication#368Vvictor-commits wants to merge 1 commit intoEDOHWARES:mainfrom
Vvictor-commits wants to merge 1 commit intoEDOHWARES:mainfrom
Conversation
- Add src/config/redis.js: shared factory that creates a Redis.Cluster when REDIS_CLUSTER_NODES is set, otherwise falls back to standalone. All Redis consumers now use this single factory. - Add src/services/deduplication.service.js: - isDuplicate(): atomic SET NX EX to mark events as seen with TTL - acquireLock(): distributed lock with Lua-script safe release - Wire deduplication into poller.js: isDuplicate() is checked before processEvent() for both regular and sequence-correlated events. - Refactor queue.js, processor.js, correlation.service.js to use the shared redis factory instead of inline Redis instantiation. - Update .env.example with REDIS_CLUSTER_NODES, DEDUP_TTL_SECONDS, DEDUP_LOCK_TTL_SECONDS. - Add __tests__/deduplication.test.js (6 tests, fully mocked). - Fix __tests__/queue.test.js to match current multi-network queue API.
|
@Vvictor-commits Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add src/config/redis.js: shared factory that creates a Redis.Cluster when REDIS_CLUSTER_NODES is set, otherwise falls back to standalone. All Redis consumers now use this single factory.
Add src/services/deduplication.service.js:
Wire deduplication into poller.js: isDuplicate() is checked before processEvent() for both regular and sequence-correlated events.
Refactor queue.js, processor.js, correlation.service.js to use the shared redis factory instead of inline Redis instantiation.
Update .env.example with REDIS_CLUSTER_NODES, DEDUP_TTL_SECONDS, DEDUP_LOCK_TTL_SECONDS.
Add tests/deduplication.test.js (6 tests, fully mocked).
Fix tests/queue.test.js to match current multi-network queue API.
closes #256