Skip to content

Conversation

@PavelVPV
Copy link

@PavelVPV PavelVPV commented Nov 12, 2025

This commit removes Authenticated Signed Write property from a characteristic and updates GATT Database hash.

The property is removed as the Data signing support is deprecated in Zephyr Bluetooth Host. See corresponding PR for Zephyr.

Affected tests:
GATT/SR/GPA/BV-04-C
GATT/SR/GAR/BV-04-C
GATT/SR/GAD/BV-04-C
GATT/SR/GAD/BV-05-C

@aescolar
Copy link
Collaborator

aescolar commented Nov 12, 2025

CC @thoh-ot @wopu-ot (please add relevant reviewers)
@MariuszSkamra @sjanc

This commit removes Authenticated Signed Write property from a
characteristic and updates GATT Database hash.

The property is removed as the Data signing support is deprecated in
Zephyr Bluetooth Host. See corresponding PR for Zephyr.

Affected tests:
GATT/SR/GPA/BV-04-C
GATT/SR/GAR/BV-04-C
GATT/SR/GAD/BV-04-C
GATT/SR/GAD/BV-05-C

Signed-off-by: Pavel Vasilyev <[email protected]>
Copy link
Collaborator

@wopu-ot wopu-ot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can agree with the general approach, but I think a comment is needed to clarify the reason for the change.

</Descriptors>
</Characteristic>
<Characteristic uuid="B011" name="Value V17" handle="176" properties="66" permissions="3">12</Characteristic>
<Characteristic uuid="B011" name="Value V17" handle="176" properties="2" permissions="3">12</Characteristic>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment that this is a deviation from the reference data base that is needed because Zephyr does not support data signing and EDTT does not support an ICS to handle this more elegantly.

@aescolar
Copy link
Collaborator

(no complaints about @wopu-ot request)
@wopu-ot question: would it make sense to document somewhere (maybe in this file itself as a comment, or anywhere else) from how this file was generated and where to find the BT SIG excel reference?
Do you guys still have the original excel macro that was used to generate this xml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants