Skip to content

[codex] fix Windows Hermes home fallback#1212

Open
sir1st wants to merge 1 commit into
EKKOLearnAI:mainfrom
sir1st:codex/fix-windows-hermes-home-fallback
Open

[codex] fix Windows Hermes home fallback#1212
sir1st wants to merge 1 commit into
EKKOLearnAI:mainfrom
sir1st:codex/fix-windows-hermes-home-fallback

Conversation

@sir1st

@sir1st sir1st commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Only use Windows LOCALAPPDATA/APPDATA Hermes homes when the directory exists.
  • Fall back to the standard ~/.hermes home so desktop bridge startup does not point at a missing C:\Users...\AppData\Local\hermes directory.
  • Keep desktop and server Hermes path detection aligned and cover the fallback behavior with tests.

Validation

  • npm run harness:check
  • npm run test -- tests/server/hermes-path.test.ts tests/server/agent-bridge-manager.test.ts
  • npm run test -- tests/server/hermes-path.test.ts
  • npm --prefix packages/desktop run build

@sir1st sir1st force-pushed the codex/fix-windows-hermes-home-fallback branch 2 times, most recently from e434b88 to 589a4d7 Compare June 1, 2026 09:29
@sir1st sir1st force-pushed the codex/fix-windows-hermes-home-fallback branch from 589a4d7 to 97add73 Compare June 1, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants