fix: add google-gemini-cli provider and fix gemini env var#1261
Open
akakoori wants to merge 2 commits into
Open
fix: add google-gemini-cli provider and fix gemini env var#1261akakoori wants to merge 2 commits into
akakoori wants to merge 2 commits into
Conversation
- Add google-gemini-cli (Google Gemini OAuth) to PROVIDER_PRESETS and PROVIDER_ENV_MAP so it appears in the Web UI model picker - Fix gemini provider to check GOOGLE_API_KEY instead of GEMINI_API_KEY (Hermes Agent uses GOOGLE_API_KEY as the canonical env var for the gemini / Google AI Studio provider; see plugins/model-providers/gemini) - Update test to include GOOGLE_API_KEY in safe provider key list The gemini provider previously required GEMINI_API_KEY, which is not the canonical env var used by Hermes Agent. This prevented users who had set GOOGLE_API_KEY (the standard var) from seeing the Google AI Studio provider in the Web UI.
Author
|
related issue #1258 |
Owner
|
这块还需要把 现在 PR 主要只是把 请补齐至少这些点：
|
Author
codex 目前好像也有这个问题? |
Owner
在我们端授权codex是没问题的 |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
google-gemini-cliprovider (Google Gemini via OAuth + Code Assist) was missing from the Web UI model picker because it was not listed inPROVIDER_PRESETSorPROVIDER_ENV_MAP.The
geminiprovider (Google AI Studio / API key) was not appearing for users who setGOOGLE_API_KEY(the canonical env var used by Hermes Agent) — the Web UI was incorrectly checkingGEMINI_API_KEYinstead.Fix
providers.ts: Addedgoogle-gemini-clipreset withcloudcode-pa://googlebase URL and standard Gemini modelsconfig-helpers.ts: Changedgeminienv var fromGEMINI_API_KEYtoGOOGLE_API_KEY(Hermes Agent canonical); addedgoogle-gemini-cliwith empty env vars (OAuth, no API key needed)profile-credentials.test.ts: AddedGOOGLE_API_KEYto safe key test listRelated