fix(update): avoid blocking install during self-update#1521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1505.
The self-update endpoint no longer runs the global
npm install -g hermes-web-ui@latestthroughexecFileSync. The update install and follow-upnpm root -glookup now use the existing asyncexecFilewrapper, so the Node event loop can continue serving requests while npm is pending. The in-process update lock is also released through afinallypath when installation fails, while successful installs keep the lock until restart handling begins.Validation
npm exec vitest -- run tests/server/update-controller.test.tsfailed because the pending async install callback was absent and the controller still usedexecFileSync.PATH=/Users/shangyifan/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH npm exec vitest -- run tests/server/update-controller.test.tsgit diff --checkPATH=/Users/shangyifan/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH npm run harness:checkPATH=/Users/shangyifan/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH npm run test:coveragePATH=/Users/shangyifan/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH npm run buildBuild completed with the existing Vite large chunk warning only.
Duplicate Check
update.ts, but only adds a cwd for the existingexecFileSyncpath to address a separateuv_cwdsystemd failure. It does not replace the synchronous update install.Browser / Playwright
Not run locally. This is server-controller behavior for
/api/hermes/update; no visible UI, browser routing, or interaction changed.